Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use fullname() for display user name #456

Closed
tatsuvalue opened this issue Mar 5, 2020 · 1 comment
Closed

Please use fullname() for display user name #456

tatsuvalue opened this issue Mar 5, 2020 · 1 comment
Labels

Comments

@tatsuvalue
Copy link

tatsuvalue commented Mar 5, 2020

The order of user names in Japanese is surname followed by first name.
for example, My name is "白井(Shirai) 達也(Tatsuya)".Shirai is surname(last name, family name), Tatsuya is first name.

In attendance report, the order of user names are right, however user name is printed out wrong order for example "達也 白井" in attendance form.

You need to modify a little bit; student_attendance_form..php, class mod_attendance_student_attendance_form, public function definition(), LINE=100,

        $radiogroup = $mform->addGroup($radioarray, 'statusarray', $USER->firstname.' '.$USER->lastname.':', array(''), false);

change to:

        $radiogroup = $mform->addGroup($radioarray, 'statusarray', fullname($USER).':', array(''), false);

This fix has no side effects in Latin-speaking countries.

image
image

@danmarsden danmarsden added the bug label Mar 8, 2020
@danmarsden
Copy link
Owner

Thanks for the report - that should definitely be using fullname there - I'll get that fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants