Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client request configuration #33

Closed
jjdodojohn opened this issue Mar 11, 2023 · 2 comments
Closed

client request configuration #33

jjdodojohn opened this issue Mar 11, 2023 · 2 comments

Comments

@jjdodojohn
Copy link

I think it would be better to set the client request url as a settable parameter since we need to replace all "http://localhost:3080" if the client and api are in different machine.

@DavesDevFails
Copy link

Yeah, probably best to set both SERVER_URL and CLIENT_URL as configurable parameters.

@wtlyu
Copy link
Contributor

wtlyu commented Mar 11, 2023

#26 replace all localhost:3080 request to relative path.
but I agree that SERVER_URL and CLIENT_URL are better design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants