Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow to change the model in existing conversation #68

Closed
wtlyu opened this issue Mar 14, 2023 · 13 comments
Closed

Disallow to change the model in existing conversation #68

wtlyu opened this issue Mar 14, 2023 · 13 comments

Comments

@wtlyu
Copy link
Contributor

wtlyu commented Mar 14, 2023

Is it possible to change the model? I'm facing some failure cases on that
@danny-avila

@danny-avila
Copy link
Owner

Can you describe the issue more? I would like to allow model switching in existing conversation. If this creates an issue, we could have it have the same effect as clicking 'new chat'

@wtlyu
Copy link
Contributor Author

wtlyu commented Mar 14, 2023

I'm understand how you can switch model in existing conversation. The big issue is the conversationId, messageId and parentMessageId are all in different scope

@wtlyu
Copy link
Contributor Author

wtlyu commented Mar 14, 2023

How can we say the conversationId of all in one conversation? and the chatgpt will not keep memory of the previous talk

@danny-avila
Copy link
Owner

the way it currently works is it resets all of those parameters, and treats any further input from user as a new conversation, it does not continue the conversation. Even though the previous conversation is in view, the only way to go back to the 'previous' conversation state is to click on the convo again

@wtlyu
Copy link
Contributor Author

wtlyu commented Mar 14, 2023

another big issue is the messageId and parentMessageId chain is break. the behavior of standard and bing version gpt is not the same ,such as:

  1. chatgpt will accept our conversationId, it's a UUID, but bing version is not, it will always generated by server, a long string. and Sydney look same as chatgpt.
  2. chatgpt allow a nonsense parentMessageId to be used, but in bingai, new conversation will be created.

@wtlyu
Copy link
Contributor Author

wtlyu commented Mar 14, 2023

So literally , you are creating a totally new conversation, just combine them and show together

@danny-avila
Copy link
Owner

So literally , you are creating a totally new conversation, just combine them and show together

Yes, they are in just in view together, but they are separate conversations

@wtlyu
Copy link
Contributor Author

wtlyu commented Mar 14, 2023

I dislike this design and it make everything toooo complete to handle. I prefer to use something like a conversationGroup. which contains several conversation to render together.

@danny-avila
Copy link
Owner

A conversation group sounds more complicated to me. The view is only rendered together during the same session that the user switches the model, it's only temporary. When the user revisits a convo, only one model is ever present in the conversation. This seemed like the most simple solution to me, and I'd rather not over-engineer this functionality when they can be delegated to new convos

@wtlyu
Copy link
Contributor Author

wtlyu commented Mar 14, 2023

For now, this will break the messageTree. because messageId and parentMessageId chain are break.

And the resubmit is also confused on which model should be used. and what is the correct conversationId (maybe use the previous one?)

@danny-avila
Copy link
Owner

If that's the case, I think the simplest solution would be to just render a new message view on model switch, that would be the equivalent to clicking new chat, what do you think?

@wtlyu
Copy link
Contributor Author

wtlyu commented Mar 14, 2023

We should also review all frontend, check if the model variable is used correctly. (use convo.model or submit.model. mostly, use convo.model is the correct one.)

Another easy solution is disable the model switch within conversation. Canbe changed only in new chat view.

@wtlyu
Copy link
Contributor Author

wtlyu commented Mar 16, 2023

now changing model will create new conversation

jinzishuai pushed a commit to jinzishuai/LibreChat that referenced this issue Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants