Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRASH WITH JA3! #322

Closed
nop4LOL opened this issue Jan 23, 2024 · 2 comments
Closed

CRASH WITH JA3! #322

nop4LOL opened this issue Jan 23, 2024 · 2 comments
Assignees
Labels
triage This ticket will be looked at shortly

Comments

@nop4LOL
Copy link

nop4LOL commented Jan 23, 2024

Description

IF OPTIONS.JA3 IS "" OR DONT GIVE JA3 PARAM , CLIENT.DO() WILL CRASH !!!!

goroutine 1 [running]: github.com/Danny-Dasilva/CycleTLS/cycletls.StringToSpec({0x0, 0x0}, {0x11c8495, 0x4c}, 0x0) F:/Program Files/Goproject/pkg/mod/github.com/!danny-!dasilva/!cycle!t!l !s/cycletls@v1.0.25/utils.go:116 +0x1157 github.com/Danny-Dasilva/CycleTLS/cycletls.(*roundTripper).dialTLS(0xa85c100, {0 x1239988, 0xa85e500}, {0x11b17dc, 0x3}, {0xa80a9b0, 0xc}) F:/Program Files/Goproject/pkg/mod/github.com/!danny-!dasilva/!cycle!t!l !s/cycletls@v1.0.25/roundtripper.go:105 +0x1d7 github.com/Danny-Dasilva/CycleTLS/cycletls.(*roundTripper).getTransport(0xa85c10 0, 0xa8767e0, {0xa80a9b0, 0xc}) F:/Program Files/Goproject/pkg/mod/github.com/!danny-!dasilva/!cycle!t!l !s/cycletls@v1.0.25/roundtripper.go:72 +0x1b1 github.com/Danny-Dasilva/CycleTLS/cycletls.(*roundTripper).RoundTrip(0xa85c100, 0xa8767e0)

**I DONT WANT EVERY REQUEST MUST APPOINT A JA3 STRING , CAN YOU PLEASE LET CYCLETLS PKG CAN SEND NORMAL HTTP REQUEST WITH DEFAULT TLS JA3 ?

JUST LIKE THIS CAN WORK IS OK ( In this latest version will CRASH ) :**

http.Do("https://google.com", cycletls.Options{}, "GET")

Issue Type

Bug

Operating System

Windows 10

Node Version

Other

Golang Version

Other

Relevant Log Output

No response

@nop4LOL nop4LOL added the triage This ticket will be looked at shortly label Jan 23, 2024
@lif0
Copy link
Contributor

lif0 commented Feb 9, 2024

Thank you🫵✨
Maybe I can fix it, I'll return the error instead of panicking, is that okay?

@Danny-Dasilva
Copy link
Owner

I've defaulted values in case they're not passed in the latest 1.0.26 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage This ticket will be looked at shortly
Projects
None yet
Development

No branches or pull requests

3 participants