Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capturing pdf from ftp produces an error #279

Open
i3v opened this issue Mar 16, 2019 · 3 comments
Open

Capturing pdf from ftp produces an error #279

i3v opened this issue Mar 16, 2019 · 3 comments
Labels

Comments

@i3v
Copy link

i3v commented Mar 16, 2019

Capturing a pdf file (either drag&drop the tab or via the main menu) from an ftp server e.g. this: ftp://iristor.vub.ac.be/patio/SURF/pub/DATAtransit%20SURF-INTERNVUB/oscars/Oxford/X-MaxN%20SEM%20DataSheet.pdf produces issues (Waterfox 56.2.8 (64-bit)):

  1. If I try to open the saved item I get urn:scrapbook-download-error:ftp://iristor.vub.ac.be/patio/SURF/pub/DATAtransit%20SURF-INTERNVUB/oscars/Oxford/X-MaxN%20SEM%20DataSheet.pdf url and the following error message from Waterfox:

The address wasn’t understood

Waterfox doesn’t know how to open this address, because one of the following protocols (urn) isn’t associated with any program or is not allowed in this context.`

  1. If I try to search through my collection, the search hangs on this item:
    image
@danny0838
Copy link
Owner

This is somehow a regression compared with ScrapBook by Gomita as we added further support for HTTP header handling. We are unlikely to fix this since it involves massive code reworking and the use of FTP in the browser is rather narrow and discouraged. You can download the file via FTP, drag it to the tree, and modify the source URL afterwards instead.

@i3v
Copy link
Author

i3v commented Mar 31, 2019

@danny0838 ,
Thanks for your reply! Yep, I can leave without ftp support. But, IMHO, the most scary part of the issue is that a fake (misleading) & broken item is created (which, in turn, breaks the search thing)... No easy way to fix this either?

@danny0838
Copy link
Owner

danny0838 commented Apr 29, 2019

Legacy ScrapBook does not implement a verification and thus saving any invalid page, such as the about:addon page, creates a "fake" item without noticeable warning, too. It is undoubtedly a bad behavior and technically fixable but by no means a small job. We might consider working on it someday.

@danny0838 danny0838 reopened this Apr 29, 2019
@danny0838 danny0838 removed the wontfix label Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants