Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not store a web page, even if it claims otherwise. #293

Open
teessl opened this issue Feb 13, 2021 · 3 comments
Open

Does not store a web page, even if it claims otherwise. #293

teessl opened this issue Feb 13, 2021 · 3 comments
Labels
bug webscrapbook Resolved by or related with WebScrapBook, the successor project.

Comments

@teessl
Copy link

teessl commented Feb 13, 2021

Hi.
First of all, thanks a lot for your work. It's a great adddon! It would be ideal if multithreaded support worked. Single thread waterfox permanently loads 1 core at 100%, the reason for staying on Single thread waterfox is for me only your scrapbook.

Waterfox Classic 2020.10 + ScrapBook X 1.14.7
Does not save this webpage:
https://www.svetplodu.cz/
Reports save complete, but then File not found. Nowhere, nothing. Changing the settings didn't help.
Thanks.

@danny0838
Copy link
Owner

danny0838 commented Feb 13, 2021

Have you confirmed that e10s is really disabled on your Waterfox? (check #235 for details)

Does capture fail only on the URL you mentioned or on any web page?

We are not going to support e10s as it's a very large code work and not everything are guarenteed to work after such rework. Go for WebScrapBook if you really want a multiprocess compatible version.

@teessl
Copy link
Author

teessl commented Feb 13, 2021

"Have you confirmed that e10s is really disabled on your Waterfox? " Yes, that's why I only use waterfox only for ScrapBook.
Otherwise, it would be great if more processes could be used.

"Does capture fail only on the URL you mentioned or on any web page?"
this.I know it's a problem to save twitter whole, but chopped. Then gigabyte product pages with subpages because it retrieves data,

but https://www.svetplodu.cz/ is so far the only site where it doesn't save anything, even incorrectly. I haven't noticed it anywhere else. I found out by wanting to comment on the page. It doesn't exist anywhere. When "saved", a popup window will appear.

Off topic, I don't know if it exists, but if subpages can be saved, can additional addresses be added?
Example of discussion. Pages 1 to 10. But it shows on main pages 1,2,3,9,10, then arrows. That whether it can be added to the list /page/4, /page/5, etc. Example: https://www.win-raid.com/t4883f52-Solution-Win-drivers-for-USB-Controllers-of-new-Intel-chipset-systems-8.html
Add addresses in filter, hard, or with some variable.

It would also be nice, I don't know if it's possible. I know there is a way to time between loading subpages. I use.
it might be useful if you could set the option to save the loaded page after a while.
Example: https://www.gigabyte.com/Motherboard/B550M-DS3H-AC-rev-1x
save with subpages: Features Specification Support News & Awards
Specification it is not saved, so it is only a part.
I solved this by storing full loaded Specification as the main ones and the others being subpages. But I didn't find out until I was looking at several years old pages, I didn't check it then.

When selected in a list of subpages to save, it would be good if they could be marked and copied to the clipboard.
This is useful because I am saving an article and I would like to have a discussion in it. I do it by having an article separately and then a discussion. I could load all the links in the discussion, them and save them in the main article.
Check selected items
Uncheck selected items
Copy to clipboard
Check all
Uncheck All

I use ScrapBook X daily. I'm so happy that you saved it! Thank you!

@danny0838 danny0838 added the bug label Feb 17, 2021
@danny0838
Copy link
Owner

"Have you confirmed that e10s is really disabled on your Waterfox? " Yes, that's why I only use waterfox only for ScrapBook.
Otherwise, it would be great if more processes could be used.

"Does capture fail only on the URL you mentioned or on any web page?"
this.I know it's a problem to save twitter whole, but chopped. Then gigabyte product pages with subpages because it retrieves data,

but https://www.svetplodu.cz/ is so far the only site where it doesn't save anything, even incorrectly. I haven't noticed it anywhere else. I found out by wanting to comment on the page. It doesn't exist anywhere. When "saved", a popup window will appear.

We have confirmed the abnormal behavior on this page https://www.svetplodu.cz/ . Unfortunately we haven't got time to do a thorough investigation.

Off topic, I don't know if it exists, but if subpages can be saved, can additional addresses be added?
Example of discussion. Pages 1 to 10. But it shows on main pages 1,2,3,9,10, then arrows. That whether it can be added to the list /page/4, /page/5, etc. Example: https://www.win-raid.com/t4883f52-Solution-Win-drivers-for-USB-Controllers-of-new-Intel-chipset-systems-8.html
Add addresses in filter, hard, or with some variable.

This feature has been implemented in WebScrapBook, by adding mergeCaptureInfo key to Capture As ....
For ScrapBook X, this requires a very large code rework, and we are probably not going to do this.

It would also be nice, I don't know if it's possible. I know there is a way to time between loading subpages. I use.
it might be useful if you could set the option to save the loaded page after a while.
Example: https://www.gigabyte.com/Motherboard/B550M-DS3H-AC-rev-1x
save with subpages: Features Specification Support News & Awards
Specification it is not saved, so it is only a part.
I solved this by storing full loaded Specification as the main ones and the others being subpages. But I didn't find out until I was looking at several years old pages, I didn't check it then.

This requires a very large code rework, and there are also some technical difficulties. We are probably not going to do this.

This feature is somehow available in WebScrapBook by using tab mode with delay key in capture as, but works slightly differently (by opening each subpage in a tab and performing the capture).

When selected in a list of subpages to save, it would be good if they could be marked and copied to the clipboard.
This is useful because I am saving an article and I would like to have a discussion in it. I do it by having an article separately and then a discussion. I could load all the links in the discussion, them and save them in the main article.
Check selected items
Uncheck selected items
Copy to clipboard
Check all
Uncheck All

Unfortunately, there may be an issue for an addon to access the clipboard...

@danny0838 danny0838 added the webscrapbook Resolved by or related with WebScrapBook, the successor project. label Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug webscrapbook Resolved by or related with WebScrapBook, the successor project.
Projects
None yet
Development

No branches or pull requests

2 participants