Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

central inv config. no hardcoded info in scripts #1

Merged
merged 1 commit into from Nov 9, 2021

Conversation

clay584
Copy link

@clay584 clay584 commented Nov 7, 2021

This PR will all you to specify all device info in a config.py file, so there will be no hardcoding of device information in the scripts themselves. This should make it easier for others to re-use your scripts in their study efforts.

@dannywade
Copy link
Owner

Thanks Clay! I really appreciate you taking a look and making the scripts better. I initially was going to try something like this, but never prioritized it since everything was running in my lab environment and the credentials weren't sensitive, but I could see how this could turn into a bigger issue if someone cloned/forked the repo and plugged in more sensitive device IPs and credentials. I'll merge your changes and talk about them during the stream tonight! Thanks again!

@dannywade dannywade merged commit ed51b6a into dannywade:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants