Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements, why? #57

Closed
danpovey opened this issue Jul 8, 2023 · 2 comments
Closed

requirements, why? #57

danpovey opened this issue Jul 8, 2023 · 2 comments

Comments

@danpovey
Copy link
Owner

danpovey commented Jul 8, 2023

@csukuangfj why does our requirements file have detailed requirements on the numpy and associated python versions?

"Cython; sys_platform=='win32' and python_version >= '3.10'",
"numpy<=1.19.5; python_version >= '3.6' and python_version < '3.7'",
"numpy<=1.21.6; python_version >= '3.7' and python_version < '3.8'",
"numpy<1.23.0; python_version >= '3.8' and python_version < '3.10'",
"numpy; python_version >= '3.10'",

Is this just what we've tested? I think we are basically only using the dlpack or whatever, no detailed features, I think?
It seems to sometimes cause problems e.g. when lhotse wants to update numpy, and it suggests a version that isn't within this requirements matrix.

@csukuangfj
Copy link
Collaborator

Is this just what we've tested?

Because it has errors when using GitHub actions to compile it.

I am retesting it and see if we can remove that constraint.

@csukuangfj
Copy link
Collaborator

csukuangfj commented Jul 8, 2023

Should be fixed by #58
Please use

pip install lilcom>=1.7

to install the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants