Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a small suggestion. :) #34

Closed
salimromadhon opened this issue Mar 18, 2014 · 2 comments
Closed

Just a small suggestion. :) #34

salimromadhon opened this issue Mar 18, 2014 · 2 comments

Comments

@salimromadhon
Copy link

The social icons were set in functions.php are not responsive with the active theme.

So, I think it would be better if you replace with this:

// Social links
function social(){

    $theme = config('views.root');
    $twitter = config('social.twitter'); 
    $facebook = config('social.facebook'); 
    $google = config('social.google'); 
    $tumblr = config('social.tumblr');
    $rss = site_url() . 'feed/rss';

    if (!empty($twitter)) {
        echo '<a href="' . $twitter . '" target="_blank"><img src="' . site_url() . $theme . '/img/twitter.png" width="32" height="32" alt="Twitter"/></a>';
    }

    if (!empty($facebook)) {
        echo '<a href="' . $facebook . '" target="_blank"><img src="' . site_url() . $theme . '/img/facebook.png" width="32" height="32" alt="Facebook"/></a>';
    }

    if (!empty($google)) {
        echo '<a href="' . $google . '" target="_blank"><img src="' . site_url() . $theme . '/img/googleplus.png" width="32" height="32" alt="Google+"/></a>';
    }

    if (!empty($tumblr)) {
        echo '<a href="' . $tumblr . '" target="_blank"><img src="' . site_url() . $theme . '/img/tumblr.png" width="32" height="32" alt="Tumblr"/></a>';
    }

    echo '<a href="' . site_url() . 'feed/rss" target="_blank"><img src="' . site_url() . $theme . '/img/rss.png" width="32" height="32" alt="RSS Feed"/></a>';

}

Just it, hope it would be the next update.

@danpros
Copy link
Owner

danpros commented Mar 18, 2014

So anyone who want to creating their own theme must provide their own icon? we should not, please read this topic #29

@salimromadhon
Copy link
Author

Ok, thank you. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants