Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual improvements #607

Closed
raffaellarinaldi opened this issue Feb 4, 2023 · 2 comments
Closed

Multilingual improvements #607

raffaellarinaldi opened this issue Feb 4, 2023 · 2 comments

Comments

@raffaellarinaldi
Copy link

raffaellarinaldi commented Feb 4, 2023

Hello,
I am loving HTMLY so far.

I use it on an Italian site with the "blog" theme.
First thing I noticed is that there are some hardcoded strings that can only be translated by manually changing the code, so I cloned the theme into a new one and changed it to my needs.

Unfortunately I noticed that some system functions that are referenced into the theme (such as pagination, breadcrumbs, etc) have hardcoded English words are cannot be translated unless I change them from the core.

For example:
functions.php

Prev/next are not translatable.

$pagination .= '<li class="page-item"><a class="page-link" href="'. $pagestring . $prev .'">« **Prev**</a></li>';
$pagination .= '<li class="page-item disabled"><span class="page-link">« **Prev**</span></li>';

htmly.php

Search results for / profile for are not translatable.

'title' => '**Search results for:** ' . tag_i18n($keyword) . ' - ' . blog_title(),
'breadcrumb' => '<a href="' . site_url() . '">' . config('breadcrumb.home') . '</a> &#187; **Search results for:** ' . 
'title' => '**Profile for:**  ' . $author->name . ' - ' . blog_title(),
'breadcrumb' => '<a href="' . site_url() . '">' . config('breadcrumb.home') . '</a> &#187; **Profile for:** ' . $author->name,

Is there any plan to make HTMLY fully translatable and turn those strings into language variables?
It would be great for international users.

Thanks!

@bttrx
Copy link
Contributor

bttrx commented Dec 2, 2023

@danpros accepts pull requests to update the core.

@danpros
Copy link
Owner

danpros commented Dec 5, 2023

Latest release should fix this problems.

@danpros danpros closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants