-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Optional refactoring #8
Comments
Thanks for asking. I haven't really thought about it, but I'd say I'm probably not too open to "code cleanup" PRs, since it runs the risk of me defamiliarizing myself with my own codebase without any direct benefit to the end user. Of course, your suggestion is a very simple one and wouldn't cause that to happen, but for the sake of keeping contribution rules clear and consistent, I'll go ahead and say that those are better as issues rather than PRs. In any case, I appreciate your interest in the project, and we can keep this issue open for the suggestion of implementing |
Valid point for sure - and something that caused me to keep PRs from others on hold as well. Regarding the benefits of Shall I work on it in a fork and just link it here for discussing, for the time being? |
Alright, I went ahead and replaced By the way, I noticed a quirk in your code which I'm not sure was intentional - apparently, you made it so that all of As for |
Hey there, Dan.
This might read a bit weird, but I'm in the habit of offering random refactorings to people so that I don't get too rusty with my Python.
I wanted to check if there's interest in PRs before going ahead, though. Still, one of the parts I thought about touching up is command-line args processing, e.g. by switching to
argparse
, which should improve that section's readability compared to the additional logic you have to use forgetopt
to give equivalent results.The text was updated successfully, but these errors were encountered: