Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example in readme is vulnerable to timing attack #56

Closed
LostKobrakai opened this issue Jul 17, 2019 · 1 comment · Fixed by #57
Closed

Example in readme is vulnerable to timing attack #56

LostKobrakai opened this issue Jul 17, 2019 · 1 comment · Fixed by #57

Comments

@LostKobrakai
Copy link

    user = Repo.get_by(User, email: username)

    cond do
      user == nil                            -> {:error, :no_user_found}
      check_pw(user.password_hash, password) -> {:ok, user}
      true                                   -> {:error, :invalid_password}
    end

Even if no user was found the pw should be checked to ensure response timings are consistent for both.

@LostKobrakai LostKobrakai changed the title Example in readme is vulnerable to timing attacks Example in readme is vulnerable to timing attack Jul 17, 2019
@danschultzer
Copy link
Owner

Thanks! I've opened #57 that improves the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants