Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do *not* use anonymous function instead of tuple for :access_token_generator, :password_auth, etc #65

Closed
OvermindDL1 opened this issue Sep 20, 2019 · 1 comment · Fixed by #66

Comments

@OvermindDL1
Copy link

Anonymous functions should absolutely never ever appear in a config file. Configuration files are loaded dynamically at code loading time, however when a release is made it gets lowered to Configuration AST and thus causes an error at release generation time due to invalid config file format. Only MFA should be used in config files, absolutely never ever should an anonymous function or closure be allowed in the config file unless it is used only at code generation time and otherwise does not get generated for releases (which would require a release configuration that does not include it).

@danschultzer
Copy link
Owner

Ugh, thanks for letting me know! I didn't think #63 through, I'll add a PR asap to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants