Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot store a token if the athlete has no email #194

Open
vandeseer opened this issue Feb 3, 2019 · 1 comment
Open

Cannot store a token if the athlete has no email #194

vandeseer opened this issue Feb 3, 2019 · 1 comment

Comments

@vandeseer
Copy link

Due to a recent change in the API one gets this error on token exchange:

Exception in thread "main" java.lang.IllegalArgumentException: Cannot store a token if the athlete has no email
	at javastrava.auth.TokenManager.storeToken(TokenManager.java:220)
	at javastrava.auth.impl.AuthorisationServiceImpl.tokenExchange(AuthorisationServiceImpl.java:41)

There is a fix for it (plus a bit more details) in this pull request: #193
@semteXKG
Copy link

is there any chance we can get this merged to master / released somewhere in the future? Can I help somehow? I just wanna know where i'm at (and if I should wait a little longer or just fork the thing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@semteXKG @vandeseer