Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#88 #90

Merged
merged 1 commit into from Oct 27, 2018
Merged

fix issue#88 #90

merged 1 commit into from Oct 27, 2018

Conversation

lowlevelm
Copy link
Contributor

@lowlevelm lowlevelm commented Oct 26, 2018

This pull request is in response to issue #88
Changes:

  • Fix accidental commenting of kanban
  • Make video in tabs.html responsive
  • make cards in kanban and kanban.js responsive

This pull request is in responce to issue#88
Changes:
- Fix accidental commenting of kanban
- Make video in tabs.html responsive
- make cards in kanban and kanban.js responsive
@diomed
Copy link
Collaborator

diomed commented Oct 26, 2018

this is nice, thank You very much, but I can't let you use<center>tag in bulma.
it has proper classes for centering.

@lowlevelm
Copy link
Contributor Author

lowlevelm commented Oct 26, 2018

i have just tried every way to center with bulma, and it doesn't work.
please submit a pull request on my fork

@diomed
Copy link
Collaborator

diomed commented Oct 26, 2018

ok. I'll look into it tomorrow.
other options are - flexbox & grid - of course.

because <center> as much simple and efficient it is, is obsolete
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/center

@diomed diomed merged commit 5468ec1 into BulmaTemplates:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants