Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of python #37

Closed
JulianGoeltz opened this issue May 17, 2021 · 5 comments · Fixed by #38
Closed

State of python #37

JulianGoeltz opened this issue May 17, 2021 · 5 comments · Fixed by #38

Comments

@JulianGoeltz
Copy link

The CHANGELOG.md states for version 2021-A

Remove Python, because it is not required in a default setup

however python is advertised both here in the Readme, and on the docker page. Is is also available locally in the container, but pip (or python -m pip) fails even though listed on the docker page. Is this intended behaviour, and if so could you please direct people in the readme on how to make pip available?
I use this container for a build process that also creates figures, and python including pip is necessary. Tonight the build process failed with No module named pip. It would be great to get it to work again, the container is of great help!
Cheers

@JulianGoeltz
Copy link
Author

Ah, sorry, now I've seen d6569dc . It seems that the python availability is by accident. I fixed it in my workflow simply with an additional

apt-get update
apt-get install -y python3-pip

I still thing (especially if python is installed anyway) that pip availability is desirable, but because it is available fixed I'm gonna close the issue. Sorry for the noise

@wallento
Copy link

I want to second that. It still has Python and adding pip seems a minimal extra, right? It broke my CI by surprise and doc should be updated to be consistent.

@JulianGoeltz
Copy link
Author

I want to second that. It still has Python and adding pip seems a minimal extra, right? It broke my CI by surprise and doc should be updated to be consistent.

@wallento do you want to reopen the issue to get a response from @koppor

@koppor
Copy link
Member

koppor commented May 20, 2021

I was not aware that my "quick fix" broke some other builds. I focused on getting minted running. --> https://github.com/dante-ev/docker-texlive/blob/main/test/minimal-minted.tex produces a highlighted pdf.

Note that python comes with the "base" image: https://gitlab.com/islandoftex/images/texlive/-/blob/master/Dockerfile.latest

Thus, "just" pip is missing. - I installed the pygments using debian's packaging system; and not using the "hacky" pip way.

Two users justify for me to include pip in this image.

Will update the CHANGELOG.md, since this is wrong.

Feel free to add PRs on this repo to keep things going. I try to look into it regularly.

@JulianGoeltz
Copy link
Author

Thanks a lot.
Love that this image exists by the way, so thank you for this as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants