Adds navigation controller wrapping overriding support to UIOperation #193 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seancatkinson
commented
Feb 21, 2016
seancatkinson
commented
- tests
|
Thanks! @seancatkinson! Very nice 👍 Let me know when you're done and I'll merge. |
|
The "wrapInNavigationController" parameter feels a bit wordy but I was struggling to think of anything more succinct. Unless you can think of something better I'm happy to merge if you're happy. |
|
Yeah, I know what you mean. I'm happy to merge it for now, I might change it later if I can think of something a little more succinct. |
danthorpe
added a commit
that referenced
this pull request
Feb 21, 2016
Adds navigation controller wrapping overriding support to UIOperation #193
|
Awesome! Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.