Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RepeatedOperation initializers #203

Merged

Conversation

danthorpe
Copy link
Member

At the moment, it's very tricky to subclass RepeatedOperation from outside the module.

  • Remove convenience initializers - as these cannot be used by subclasses.
  • Try to minimize the messy initialization code.
  • Unify / Cleanup / Remove the Repeatable & RepeatedOperation stuff - I think this has got a bit confused since it was first written.

This is to address issues raised in #199.

@danthorpe danthorpe self-assigned this Feb 25, 2016
@danthorpe danthorpe added this to the 2.7 milestone Feb 25, 2016
@danthorpe
Copy link
Member Author

@jshier - I've made a start on these changes. Currently everything is passing tests (CI is currently failing only because coverage has dropped).

Let me know what you think - hopefully should be much easier to subclass these.

@danthorpe
Copy link
Member Author

This is all looking good now. I renamed RepeatedGenerator to RepeatableGenerator and made it public. This is because I cannot get around having the initializer for when T: Repeatable a designated initializer, because it's in a constrained extension.

danthorpe added a commit that referenced this pull request Feb 27, 2016
…tion_initializers

Refactor RepeatedOperation initializers
@danthorpe danthorpe merged commit 02f0749 into development Feb 27, 2016
@danthorpe danthorpe deleted the feature/OPR-203_repeated_operation_initializers branch February 27, 2016 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant