Fix suspected retain cycles in result injection #223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Courtesy of @estromlund. These appear to be retain cycles; the
previous
operation is added as a dependency of thesubsequent
operation, but the block retains thesubsequent
operation, so we would seem to have a clear retain cycle. Certainly adding this fixed some cycles for us. Please let us know if you think we might be using things incorrectly.Thanks!