Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing XMR wallet breaks jsonrpclib #5

Open
danuker opened this issue Jun 18, 2018 · 1 comment
Open

Closing XMR wallet breaks jsonrpclib #5

danuker opened this issue Jun 18, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@danuker
Copy link
Owner

danuker commented Jun 18, 2018

When attempting to close the XMR wallet (server.stop_wallet()), the response received by jsonrpclib is None, and it can't get its result.

This only happens sometimes.

Find out why and fix it, so that we can make sure the wallet is stopped.

Stopping RPC server for XMR...
Traceback (most recent call last):
  File "./demo.py", line 87, in <module>
    main()
  File "./demo.py", line 81, in main
    mp.stop_servers()
  File "/home/dan/PycharmProjects/Piggies/piggies/master_piggy.py", line 55, in stop_servers
    self.piggies[p].stop_server()
  File "/home/dan/PycharmProjects/Piggies/piggies/piggy_xmr.py", line 146, in stop_server
    self.server.stop_wallet()
  File "/usr/local/lib/python2.7/dist-packages/jsonrpclib/jsonrpc.py", line 290, in __call__
    return self.__send(self.__name, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/jsonrpclib/jsonrpc.py", line 239, in _request
    return response['result']
TypeError: 'NoneType' object has no attribute '__getitem__'
@danuker danuker added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jun 18, 2018
@danuker
Copy link
Owner Author

danuker commented Jun 20, 2018

Marked as an enhancement, since now it doesn't crash anymore, but we should make sure that the wallet stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant