Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip ignite says it is Python3 compatible... it is not... but almost: only 3 changes needed (make a branch if you wish) #3

Open
yumok opened this issue Oct 21, 2017 · 0 comments

Comments

@yumok
Copy link

yumok commented Oct 21, 2017

(I don't want to make a pull request, because the changes break python2 compatibility... a new python3 branch would be better)
Had to change only 3 things to make it work in python3:

in "init.py":
from .ignite import *

in "ignite.py":
params.iteritems() must be changed for iter(params.items())
urllib.urlencode changed for urllib.parse.urlencode

and now it works in python3

Links to my fork:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant