method inUiThread was not working as expected #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bipinvaylu
reviewed
Nov 19, 2021
| @@ -669,6 +669,8 @@ public String toString() { | |||
| } | |||
|
|
|||
| private boolean inUiThread() { | |||
| return Thread.currentThread().getId() == 1; | |||
| // return Thread.currentThread().getId() == 1; | |||
| return Looper.myLooper() == Looper.getMainLooper() | |||
There was a problem hiding this comment.
hey @upender-reddy forgot to add semicolon as it's .java file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App was crashing with RuntimeException("this should be called in Main Thread")
due to method "inUiThread" returning false even though it is running in main thread .
After changing logic to check the main thread app is working fine.