-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring codebase #61
Comments
No, the code is a little bit messy lol (I did not have a good understanding of Lua at the time) Feel free to open a PR, and let me know what do you plan to refactor ;) |
I'm looking |
Sure, thanks for your contribution ! 💯 |
Are you using extmarks because you want to support inserting a new line for the comments? If yes, I think must use extmarks or marks, but extmarks are better than the limited marks. |
What do you mean exactly ? |
Once the template is generated, the positions are computed that are immutable, but the position of extmarks are mutable.
|
Oh yeah, I use extmarks because we can jump between annotation types even after we create some annotation and modify the lines |
Thanks, I will deep into the codebase and refactor it later, maybe tomorrow or the day after tomorrow. |
No problem, take your time, feel free to ping me if you need anything |
Why neogen/lua/neogen/generators/default.lua Line 96 in 271260c
|
Yes, during initial development it was assumed we could pass templates as functions, but I guess we'll not use them anymore. Even the granulator and generator, I'm not really found of creating your own. |
Thanks, refactor is going to be done, WIP in my local repo.
I'm doing this idea, but I have no idea how to write the doc and tell the users what's the change is breaking. |
No worries, I will update the docs in your pr before merging |
It sounds harsh, but I like the idea of this plugin. If you don't mind, I will make a PR with help.
The text was updated successfully, but these errors were encountered: