Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove .scss.d.ts files from version control, as they are generated by webpack #838

Closed
jellegerbrandy opened this issue Jun 26, 2019 · 2 comments · Fixed by #923
Closed

remove .scss.d.ts files from version control, as they are generated by webpack #838

jellegerbrandy opened this issue Jun 26, 2019 · 2 comments · Fixed by #923
Assignees
@dkent600

Comments

@jellegerbrandy
Copy link
Contributor

No description provided.

@jellegerbrandy jellegerbrandy mentioned this issue Jul 12, 2019
Closed
19 tasks
@leviadam
Copy link
Contributor

leviadam commented Jul 15, 2019 •
edited
Loading

@jellegerbrandy
Is there a reference that this is indeed the common practice?
I also don't see webpack is generating them. If I delete one of them and then do npm run build I get an error.

@jellegerbrandy jellegerbrandy mentioned this issue Jul 16, 2019
Merged
@jellegerbrandy
Copy link
Contributor Author

the error is because of a bug: Jimdo/typings-for-css-modules-loader#33
This workaroudn seems to work, cf. #923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkent600 dkent600

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

838 remove scss.d.ts daostack/alchemy
3 participants
@jellegerbrandy @dkent600 @leviadam