Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "isSupportedContract" to "supportsInterface" #1

Open
chrisaxiom opened this issue Nov 23, 2018 · 2 comments
Open

Rename "isSupportedContract" to "supportsInterface" #1

chrisaxiom opened this issue Nov 23, 2018 · 2 comments
Assignees

Comments

@chrisaxiom
Copy link

"isSupportedContract" is just made up, the correct method name is "supportsInterface"

cc @pazams

@chrisaxiom chrisaxiom self-assigned this Nov 23, 2018
@pazams
Copy link
Contributor

pazams commented Nov 29, 2018

isSupportedContract(contract c) is a made up wrapper and defined to be equal to : c.supportsInterface(interface a) or c.supportsInterface(interface b)

Since a and b are hardcoded, it made sense to me to make the wrapper name different.

@chrisaxiom
Copy link
Author

How about supportsInterfaces instead? Makes it clearer as to what it is actually doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants