This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
Loose coupling of pallets: Roles + Social #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Subsocial <62490051+subsocialdev@users.noreply.github.com>
Co-Authored-By: siman <aleksandr.siman@gmail.com>
subsocialdev
changed the title
Closed
4 tasks
Co-Authored-By: siman <aleksandr.siman@gmail.com>
- Move traits from `pallet-utils` to `df-traits` Co-Authored-By: siman <aleksandr.siman@gmail.com>
Co-Authored-By: siman <aleksandr.siman@gmail.com>
- Fix errors related to previous refactors - Fix code style in `pallet-social/src/functions` Co-Authored-By: siman <aleksandr.siman@gmail.com>
Co-Authored-By: siman <aleksandr.siman@gmail.com>
Co-Authored-By: siman <aleksandr.siman@gmail.com>
Co-Authored-By: siman <aleksandr.siman@gmail.com>
- Use SpacePermissions checks when needed. - Remove enable_role and disable_role and add a field in RoleUpdate.
Co-Authored-By: siman <aleksandr.siman@gmail.com>
subsocialdev
commented
Jun 4, 2020
pallets/roles/src/lib.rs
Outdated
| /// There's too many users assigned for this role to delete it | ||
| TooManyUserAssignedToDeleteRole, | ||
| TooManyUserForDeleteRole, | ||
|
|
||
| /// No roles found for this User on specified Space | ||
| NoAnyRolesForUserOnSpace, |
There was a problem hiding this comment.
Suggested change
| NoAnyRolesForUserOnSpace, | |
| NoRolesForUserInSpace, |
Update some types.json
siman
approved these changes
Jun 5, 2020
siman
suggested changes
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.