This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
Split social's functions into more files #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F3Joule
suggested changes
Jun 10, 2020
Comment on lines
+6
to
+8
| decl_error, decl_event, decl_module, decl_storage, dispatch::DispatchError, | ||
| ensure, | ||
| traits::Get |
There was a problem hiding this comment.
Suggested change
| decl_error, decl_event, decl_module, decl_storage, dispatch::DispatchError, | |
| ensure, | |
| traits::Get | |
| decl_error, decl_event, decl_module, decl_storage, | |
| dispatch::DispatchError, | |
| traits::Get, | |
| ensure |
Earlier in PR dependencies were organized in this way (macro first, single crate deps last).
| impl<T: Trait> Module<T> { | ||
|
|
||
| // FIXME: don't add reaction in storage before the checks in 'create_reaction' are done | ||
| pub fn insert_new_reaction(account: T::AccountId, kind: ReactionKind) -> ReactionId { |
There was a problem hiding this comment.
Maybe move it to impl<T: Trait> Reaction<T> {}?
Makes sense due to we use that principle with Space/Post for expample.
subsocialdev
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.