Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some minor suggestions #3

Open
rolfyone opened this issue Jan 19, 2022 · 3 comments
Open

some minor suggestions #3

rolfyone opened this issue Jan 19, 2022 · 3 comments

Comments

@rolfyone
Copy link

I really like how this is coming together!

A couple of little things from a short play...

  • there's often a list of validators, and a list of passwords in files. so I might have
keys / b1d7938_validator.json
passwords / b1d7938_validator.txt

and being able to drag keys, then drag passwords and have it fill somehow?

  • Pagination is great, maybe configurable (10 / 50 / 250 / all or something)? I don't mind scrolling down the page, sometimes I have over 100 validators on an instance and finding things can be painful. Filtering on readonly=false would be a good UX for this one, but fairly specific to teku users i think...

  • if imports are more than about 10, it might pay to move to a tabular format... also in that table you could potentially have a checkbox for if there was slashing protection data found in the provided data? for example, if i add even 1 key then provide an empty slashing data file, i could then see that I haven't provided data for that key...

  • Currently teku raises a 400 if on import slashing_protection = "" on an import, as it expects that field to have real data if it's populated. I think other clients may act the same on this from discussions on discord...

@joaquim-verges
Copy link
Collaborator

  • the slashing_protection = "" issue should be fixed!
  • for the pagination, I can increase it to 50, should be enough for most ppl i think.
  • agree that massive imports are painful right now, i'll think of ways to improve it. And adding some polish to the slashing protection data UX, right now it's super bare bones.

Thanks for the feedback!

@joaquim-verges
Copy link
Collaborator

@rolfyone made page size configurable 👍

@rolfyone
Copy link
Author

Awesome :) thanks for the update! I'll probably be playing with this again tomorrow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants