Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --wait flag to dapr init and dapr upgrade #597

Closed
DarqueWarrior opened this issue Feb 12, 2021 · 0 comments · Fixed by #629
Closed

Add --wait flag to dapr init and dapr upgrade #597

DarqueWarrior opened this issue Feb 12, 2021 · 0 comments · Fixed by #629
Assignees
Milestone

Comments

@DarqueWarrior
Copy link

DarqueWarrior commented Feb 12, 2021

Describe the proposal

When using infrastructure as code in a DevOps pipeline my K8s cluster is created and I then run dapr init and helm install (of my application) if you do that too quickly no side cars will be injected into my pods because the dapr containers are still being created.

This required me to write custom logic to repeatedly calling dapr status and checking if I found the word false or not. This works but makes my pipeline fragile. If the output of dapr status were to change my pipeline would fail.

If dapr init and dapr upgrade offered a --wait flag that would cause the call to block until all the containers are healthy would eliminate the need for customer implementations of waiting logic.

Release Note

RELEASE NOTE: ADDED --wait flag for init and upgrade commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants