Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pubsub][pulsar]Support pulsar+ssl:// URL format #1860

Closed
Kyle2123 opened this issue Jul 7, 2022 · 3 comments
Closed

[pubsub][pulsar]Support pulsar+ssl:// URL format #1860

Kyle2123 opened this issue Jul 7, 2022 · 3 comments
Labels
kind/enhancement New feature or request stale

Comments

@Kyle2123
Copy link

Kyle2123 commented Jul 7, 2022

Describe the feature

Currently the pulsar pubsub component expects the Pulsar url to be in one of three formats:

  • pulsar://
  • http://
  • https://

Please add support for the pulsar+ssl:// format to allow for connections to production Pulsar clusters that are configured to use TLS.

pulsarPrefix = "pulsar://"

if !strings.HasPrefix(m.Host, "http://") &&
!strings.HasPrefix(m.Host, "https://") {
pulsarURL = fmt.Sprintf("%s%s", pulsarPrefix, m.Host)
}

@Kyle2123 Kyle2123 added the kind/enhancement New feature or request label Jul 7, 2022
@ItalyPaleAle
Copy link
Contributor

Hey @Kyle2123 thanks for opening this issue! Would you be able to submit a PR for this?

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Aug 16, 2022
@dapr-bot
Copy link
Collaborator

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request stale
Projects
None yet
3 participants