Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Priority Queues in RabbitMQ with pubsub #2029

Closed
kayvonkhosrowpour opened this issue Aug 29, 2022 · 8 comments · Fixed by #2680
Closed

Support for Priority Queues in RabbitMQ with pubsub #2029

kayvonkhosrowpour opened this issue Aug 29, 2022 · 8 comments · Fixed by #2680
Assignees
Labels
help wanted Extra attention is needed kind/enhancement New feature or request pinned Issue does not get stale
Milestone

Comments

@kayvonkhosrowpour
Copy link

Describe the feature

RabbitMQ supports the ability to create priority queues through the x-max-priority property. Although dapr supports priority queues through the maxPriority attribute in the binding spec, there is no support in pubsub.

This feature request is to support the ability to create priority queues in the rabbitMQ pubsub component definition. Ideally, we would be able to create priority queues off a topic by name or pattern. For example, I have an exchange called "primary", and I have queues off the exchange called A, B, C. I only need C to be a priority queue, so I should be able to designate priority-C as having priority, whereas priority-A and priority-B do not need to have priority.

Please let me know what additional information would be helpful.

Potential

apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
  name: priority
spec:
  type: pubsub.rabbitmq
  version: v1
  metadata:
  # ...
  # standard config
  # ...
  - name: maxPriorities
     value:
         C: 5 # this specifies the max priority for queue C off exchange topic "priority"

Release Note

RELEASE NOTE: ADD New feature in Dapr - RabbitMQ priority queue support in pubsub component

@kayvonkhosrowpour kayvonkhosrowpour added the kind/enhancement New feature or request label Aug 29, 2022
@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Sep 28, 2022
@kayvonkhosrowpour
Copy link
Author

@yaron2 @berndverst @artursouza -- Any chance we can support this? Issue will be closed soon

@dapr-bot dapr-bot removed the stale label Sep 29, 2022
@a2bondar
Copy link

This would be excellent for us as well. What is needed to get this added to release schedule?

@Taction
Copy link
Member

Taction commented Sep 30, 2022

Better add this config in the metadata of Subscription config, such as:

apiVersion: dapr.io/v1alpha1
kind: Subscription
metadata:
  name: order
spec:
  topic: orders
  route: /checkout
  pubsubname: pubsub
  metadata:
  - name: maxPriorities
     value: "10"

and handle this metadata in the rabbitmq pubsub component. Also, add a metadata specifying priority per message level.
@kayvonkhosrowpour are you interested in submitting ap pr for this?

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Oct 30, 2022
@adawalli
Copy link

/remove-stale

@dapr-bot dapr-bot removed the stale label Oct 31, 2022
@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Nov 30, 2022
@adawalli
Copy link

/remove-stale

@berndverst berndverst added pinned Issue does not get stale and removed stale labels Nov 30, 2022
@berndverst berndverst added the help wanted Extra attention is needed label Jan 18, 2023
@yaron2 yaron2 added this to the v1.11 milestone Mar 15, 2023
@yaron2 yaron2 self-assigned this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/enhancement New feature or request pinned Issue does not get stale
Projects
None yet
7 participants