Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL state store v2 #2956

Closed
ItalyPaleAle opened this issue Jun 30, 2023 · 7 comments · Fixed by #3250
Closed

PostgreSQL state store v2 #2956

ItalyPaleAle opened this issue Jun 30, 2023 · 7 comments · Fixed by #3250
Assignees
Labels
kind/enhancement New feature or request P2 pinned Issue does not get stale
Milestone

Comments

@ItalyPaleAle
Copy link
Contributor

ItalyPaleAle commented Jun 30, 2023

As we now have "v2" components, we should look into creating a v2 of the Postgres state store to address some long-standing issues:

  • Do not use the xmin column for etags, but a more "traditional" column
  • The implementation of the "v2" component will be 100% identical to the current CockroachDB implementation, and we can also expose it as YugabyteDB (Support YugabyteDB as a State Store #2529). We should be able to reuse pretty much all code, but simplify the migration code.
  • We do not plan on deprecating the "v1" at present
  • Tests (conformance and certification) should run for both v1 and v2
@ItalyPaleAle ItalyPaleAle added the kind/enhancement New feature or request label Jun 30, 2023
@ItalyPaleAle ItalyPaleAle added this to the v1.12 milestone Jun 30, 2023
@ItalyPaleAle ItalyPaleAle self-assigned this Jun 30, 2023
@ItalyPaleAle ItalyPaleAle added P1 P2 and removed P1 labels Jun 30, 2023
@ItalyPaleAle
Copy link
Contributor Author

Moving this to P2 for now. Although the issues above are good reasons for a "v2", we are not sure if they're "good enough" by themselves. We may wait a bit on this to see if there's something else that comes up that could require a v2 of the component.

CC: @artursouza

@ItalyPaleAle ItalyPaleAle modified the milestones: v1.12, v1.13 Jul 3, 2023
@ymahajan
Copy link

  1. When is this expected to be released?
  2. After this V2 change, will YugabyteDB be published as a separate state store?

@berndverst
Copy link
Member

  1. When is this expected to be released?
  2. After this V2 change, will YugabyteDB be published as a separate state store?

There is no timeline. This is not one of our highest priorities right now and there are some decisions we need to carefully make as maintainers. When this is completed YugabyteDB can be added as a separate state store, but until then please wait for this issue to be closed before inquiring further.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 23, 2023
@yaron2 yaron2 removed the stale label Aug 24, 2023
@yaron2
Copy link
Member

yaron2 commented Aug 24, 2023

keep-alive

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 23, 2023
@ItalyPaleAle ItalyPaleAle added pinned Issue does not get stale and removed stale labels Sep 23, 2023
@olitomlinson
Copy link

Document how users can inspect the content of a value i.e. this is outlined here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request P2 pinned Issue does not get stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants