-
Notifications
You must be signed in to change notification settings - Fork 1.8k
/
reminders.go
1178 lines (1032 loc) · 36.9 KB
/
reminders.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
Copyright 2023 The Dapr Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package reminders
import (
"bytes"
"context"
"encoding/json"
"errors"
"fmt"
"strings"
"sync"
"sync/atomic"
"time"
"github.com/cenkalti/backoff/v4"
"github.com/google/uuid"
"google.golang.org/protobuf/proto"
"google.golang.org/protobuf/types/known/timestamppb"
"k8s.io/utils/clock"
"github.com/dapr/components-contrib/state"
"github.com/dapr/dapr/pkg/actors/internal"
diag "github.com/dapr/dapr/pkg/diagnostics"
internalv1pb "github.com/dapr/dapr/pkg/proto/internals/v1"
"github.com/dapr/dapr/pkg/resiliency"
"github.com/dapr/kit/logger"
"github.com/dapr/kit/retry"
)
var log = logger.NewLogger("dapr.runtime.actor.reminders")
const (
daprSeparator = "||"
metadataPartitionKey = "partitionKey"
)
type remindersMetricsCollectorFn = func(actorType string, reminders int64)
// Implements a reminders provider.
type reminders struct {
clock clock.WithTicker
apiLevel *atomic.Uint32
runningCh chan struct{}
executeReminderFn internal.ExecuteReminderFn
remindersLock sync.RWMutex
reminders map[string][]ActorReminderReference
activeReminders *sync.Map
evaluationChan chan struct{}
evaluationQueue chan struct{}
stateStoreProviderFn internal.StateStoreProviderFn
resiliency resiliency.Provider
config internal.Config
lookUpActorFn internal.LookupActorFn
metricsCollector remindersMetricsCollectorFn
}
// NewRemindersProviderOpts contains the options for the NewRemindersProvider function.
type NewRemindersProviderOpts struct {
StoreName string
Config internal.Config
APILevel *atomic.Uint32
}
// NewRemindersProvider returns a reminders provider.
func NewRemindersProvider(opts internal.ActorsProviderOptions) internal.RemindersProvider {
return &reminders{
clock: opts.Clock,
apiLevel: opts.APILevel,
runningCh: make(chan struct{}),
reminders: map[string][]ActorReminderReference{},
activeReminders: &sync.Map{},
evaluationChan: make(chan struct{}, 1),
evaluationQueue: make(chan struct{}, 1),
config: opts.Config,
resiliency: opts.Resiliency,
metricsCollector: diag.DefaultMonitoring.ActorReminders,
}
}
func (r *reminders) SetExecuteReminderFn(fn internal.ExecuteReminderFn) {
r.executeReminderFn = fn
}
func (r *reminders) SetStateStoreProviderFn(fn internal.StateStoreProviderFn) {
r.stateStoreProviderFn = fn
}
func (r *reminders) SetLookupActorFn(fn internal.LookupActorFn) {
r.lookUpActorFn = fn
}
func (r *reminders) SetMetricsCollectorFn(fn remindersMetricsCollectorFn) {
r.metricsCollector = fn
}
// OnPlacementTablesUpdated is invoked when the actors runtime received an updated placement tables.
func (r *reminders) OnPlacementTablesUpdated(ctx context.Context) {
go func() {
// To handle bursts, use a queue so no more than one evaluation can be queued up at the same time, since they'd all fetch the same data anyways
select {
case r.evaluationQueue <- struct{}{}:
// Queue isn't full
default:
// There's already one invocation in the queue so no need to queue up another one
return
}
// r.evaluationQueue is released in the handler after obtaining the evaluationChan lock
r.evaluateReminders(ctx)
}()
}
func (r *reminders) DrainRebalancedReminders(actorType string, actorID string) {
r.remindersLock.RLock()
reminders := r.reminders[actorType]
r.remindersLock.RUnlock()
for _, rem := range reminders {
// rem.Reminder refers to the actual reminder struct that is saved in the db
if rem.Reminder.ActorType != actorType || rem.Reminder.ActorID != actorID {
continue
}
reminderKey := rem.Reminder.Key()
stopChan, exists := r.activeReminders.LoadAndDelete(reminderKey)
if exists {
close(stopChan.(chan struct{}))
}
}
}
func (r *reminders) CreateReminder(ctx context.Context, reminder *internal.Reminder) error {
storeName, store, err := r.stateStoreProviderFn()
if err != nil {
return err
}
// Wait for the evaluation chan lock
if !r.waitForEvaluationChan() {
return errors.New("error creating reminder: timed out after 30s")
}
defer func() {
// Release the evaluation chan lock
<-r.evaluationChan
}()
existing, ok := r.getReminder(reminder.Name, reminder.ActorType, reminder.ActorID)
if ok {
if existing.RequiresUpdating(reminder) {
err = r.doDeleteReminder(ctx, reminder.ActorType, reminder.ActorID, reminder.Name)
if err != nil {
return err
}
} else {
return nil
}
}
stop := make(chan struct{})
config := retry.DefaultConfig()
config.Multiplier = 1.0
b := config.NewBackOffWithContext(ctx)
err = retry.NotifyRecover(
func() error {
innerErr := r.storeReminder(ctx, storeName, store, reminder, stop)
if innerErr != nil {
// If the etag is mismatched, we can retry the operation.
if isEtagMismatchError(innerErr) {
return innerErr
}
log.Errorf("Error storing reminder: %v", innerErr)
return backoff.Permanent(innerErr)
}
return nil
},
b,
func(err error, d time.Duration) {
log.Debugf("Attempting to store reminder again after error: %v", err)
},
func() {
log.Debug("Storing of reminder successful")
},
)
if err != nil {
return err
}
// Start the reminder
return r.startReminder(reminder, stop)
}
func (r *reminders) Close() error {
// Close the runningCh
close(r.runningCh)
return nil
}
func (r *reminders) Init(ctx context.Context) error {
return nil
}
func (r *reminders) GetReminder(ctx context.Context, req *internal.GetReminderRequest) (*internal.Reminder, error) {
list, _, err := r.getRemindersForActorType(ctx, req.ActorType, false)
if err != nil {
return nil, err
}
for _, r := range list {
if r.Reminder.ActorID == req.ActorID && r.Reminder.Name == req.Name {
return &internal.Reminder{
Data: r.Reminder.Data,
DueTime: r.Reminder.DueTime,
Period: r.Reminder.Period,
}, nil
}
}
return nil, nil
}
func (r *reminders) DeleteReminder(ctx context.Context, req internal.DeleteReminderRequest) error {
if !r.waitForEvaluationChan() {
return errors.New("error deleting reminder: timed out after 30s")
}
defer func() {
// Release the evaluation chan lock
<-r.evaluationChan
}()
config := retry.DefaultConfig()
config.Multiplier = 1.0
b := config.NewBackOffWithContext(ctx)
err := retry.NotifyRecover(
func() error {
innerErr := r.doDeleteReminder(ctx, req.ActorType, req.ActorID, req.Name)
if innerErr != nil {
// If the etag is mismatched, we can retry the operation.
if isEtagMismatchError(innerErr) {
return innerErr
}
log.Errorf("Error deleting reminder: %v", innerErr)
return backoff.Permanent(innerErr)
}
return nil
},
b,
func(err error, d time.Duration) {
log.Debugf("Attempting to delete reminder again after error: %v", err)
},
func() {
log.Debug("Deletion of reminder successful")
},
)
if err != nil {
return err
}
return nil
}
func (r *reminders) evaluateReminders(ctx context.Context) {
// Wait for the evaluation channel
select {
case r.evaluationChan <- struct{}{}:
// All good, continue
case <-r.runningCh:
// Processor is shutting down
<-r.evaluationQueue
return
}
defer func() {
// Release the evaluation chan lock
<-r.evaluationChan
}()
// Allow another evaluation operation to get queued up
<-r.evaluationQueue
if r.config.HostedActorTypes == nil {
log.Info("hostedActorTypes is nil, skipping reminder evaluation")
return
}
var wg sync.WaitGroup
ats := r.config.HostedActorTypes.ListActorTypes()
for _, t := range ats {
vals, _, err := r.getRemindersForActorType(ctx, t, true)
if err != nil {
log.Errorf("Error getting reminders for actor type %s: %s", t, err)
continue
}
log.Debugf("Loaded %d reminders for actor type %s", len(vals), t)
r.remindersLock.Lock()
r.reminders[t] = vals
r.remindersLock.Unlock()
wg.Add(1)
go func() {
defer wg.Done()
for i := range vals {
rmd := vals[i].Reminder
reminderKey := rmd.Key()
isLocalActor, targetActorAddress := r.lookUpActorFn(ctx, rmd.ActorType, rmd.ActorID)
if targetActorAddress == "" {
log.Warn("Did not find address for actor for reminder " + reminderKey)
continue
}
if isLocalActor {
stop := make(chan struct{})
_, exists := r.activeReminders.LoadOrStore(reminderKey, stop)
if !exists {
err := r.startReminder(&rmd, stop)
if err != nil {
log.Errorf("Error starting reminder %s: %v", reminderKey, err)
} else {
log.Debug("Started reminder " + reminderKey)
}
} else {
log.Debug("Reminder " + reminderKey + " already exists")
}
} else {
stopChan, exists := r.activeReminders.LoadAndDelete(reminderKey)
if exists {
log.Debugf("Stopping reminder %s on %s as it's active on host %s", reminderKey, r.config.HostAddress, targetActorAddress)
close(stopChan.(chan struct{}))
}
}
}
}()
}
wg.Wait()
}
func (r *reminders) waitForEvaluationChan() bool {
t := r.clock.NewTimer(30 * time.Second)
select {
// Evaluation channel was not freed up in time
case <-t.C():
return false
// The provider is shutting down
case <-r.runningCh:
if !t.Stop() {
<-t.C()
}
return false
// Evaluation chan is available
case r.evaluationChan <- struct{}{}:
if !t.Stop() {
<-t.C()
}
return true
}
}
func (r *reminders) getReminder(reminderName string, actorType string, actorID string) (*internal.Reminder, bool) {
r.remindersLock.RLock()
reminders := r.reminders[actorType]
r.remindersLock.RUnlock()
for _, r := range reminders {
if r.Reminder.ActorID == actorID && r.Reminder.ActorType == actorType && r.Reminder.Name == reminderName {
return &r.Reminder, true
}
}
return nil, false
}
func (r *reminders) doDeleteReminder(ctx context.Context, actorType, actorID, name string) error {
storeName, store, err := r.stateStoreProviderFn()
if err != nil {
return err
}
reminderKey := constructCompositeKey(actorType, actorID, name)
stop, exists := r.activeReminders.LoadAndDelete(reminderKey)
if exists {
log.Debugf("Found reminder with key: %s. Deleting reminder", reminderKey)
close(stop.(chan struct{}))
}
var policyDef *resiliency.PolicyDefinition
if r.resiliency != nil && !r.resiliency.PolicyDefined(storeName, resiliency.ComponentOutboundPolicy) {
// If there is no policy defined, wrap the whole logic in the built-in.
policyDef = r.resiliency.BuiltInPolicy(resiliency.BuiltInActorReminderRetries)
} else {
// Else, we can rely on the underlying operations all being covered by resiliency.
noOp := resiliency.NoOp{}
policyDef = noOp.EndpointPolicy("", "")
}
policyRunner := resiliency.NewRunner[bool](ctx, policyDef)
found, err := policyRunner(func(ctx context.Context) (bool, error) {
reminders, actorMetadata, rErr := r.getRemindersForActorType(ctx, actorType, false)
if rErr != nil {
return false, fmt.Errorf("error obtaining reminders for actor type %s: %w", actorType, rErr)
}
// Remove from partition first
found, remindersInPartition, stateKey, etag := actorMetadata.removeReminderFromPartition(reminders, actorType, actorID, name)
// If the reminder doesn't exist, stop here
if !found {
return false, nil
}
// Now, we can remove from the "global" list.
n := 0
for _, v := range reminders {
if v.Reminder.ActorType != actorType ||
v.Reminder.ActorID != actorID || v.Reminder.Name != name {
reminders[n] = v
n++
}
}
reminders = reminders[:n]
// Get the database partiton key (needed for CosmosDB)
databasePartitionKey := actorMetadata.calculateDatabasePartitionKey(stateKey)
// Check if context is still valid
rErr = ctx.Err()
if rErr != nil {
return false, fmt.Errorf("context error before saving reminders: %w", rErr)
}
// Save the partition in the database, in a transaction where we also save the metadata.
// Saving the metadata too avoids a race condition between an update and repartitioning.
stateMetadata := map[string]string{
metadataPartitionKey: databasePartitionKey,
}
partitionOp, rErr := r.saveRemindersInPartitionRequest(stateKey, remindersInPartition, etag, stateMetadata)
if rErr != nil {
return false, fmt.Errorf("failed to create request for storing reminders: %w", rErr)
}
stateOperations := []state.TransactionalStateOperation{
partitionOp,
r.saveActorTypeMetadataRequest(actorType, actorMetadata, stateMetadata),
}
rErr = r.executeStateStoreTransaction(ctx, storeName, store, stateOperations, stateMetadata)
if rErr != nil {
return false, fmt.Errorf("error saving reminders partition and metadata: %w", rErr)
}
if r.metricsCollector != nil {
r.metricsCollector(actorType, int64(len(reminders)))
}
r.remindersLock.Lock()
r.reminders[actorType] = reminders
r.remindersLock.Unlock()
return true, nil
})
if err != nil {
return err
}
if !found {
// Reminder was not found, so nothing to do here
return nil
}
if r.resiliency != nil && !r.resiliency.PolicyDefined(storeName, resiliency.ComponentOutboundPolicy) {
policyDef = r.resiliency.ComponentOutboundPolicy(storeName, resiliency.Statestore)
} else {
// Else, we can rely on the underlying operations all being covered by resiliency.
noOp := resiliency.NoOp{}
policyDef = noOp.EndpointPolicy("", "")
}
deletePolicyRunner := resiliency.NewRunner[struct{}](ctx, policyDef)
deleteReq := &state.DeleteRequest{
Key: reminderKey,
}
_, err = deletePolicyRunner(func(ctx context.Context) (struct{}, error) {
return struct{}{}, store.Delete(ctx, deleteReq)
})
return err
}
func (r *reminders) storeReminder(ctx context.Context, storeName string, store internal.TransactionalStateStore, reminder *internal.Reminder, stopChannel chan struct{}) error {
// Store the reminder in active reminders list
reminderKey := reminder.Key()
stored, loaded := r.activeReminders.LoadOrStore(reminderKey, stopChannel)
if loaded {
// If the value was loaded, we have a race condition: another goroutine is trying to store the same reminder
return fmt.Errorf("failed to store reminder %s: reminder was created concurrently by another goroutine", reminderKey)
}
var policyDef *resiliency.PolicyDefinition
if r.resiliency != nil && !r.resiliency.PolicyDefined(storeName, resiliency.ComponentOutboundPolicy) {
// If there is no policy defined, wrap the whole logic in the built-in.
policyDef = r.resiliency.BuiltInPolicy(resiliency.BuiltInActorReminderRetries)
} else {
// Else, we can rely on the underlying operations all being covered by resiliency.
noOp := resiliency.NoOp{}
policyDef = noOp.EndpointPolicy("", "")
}
policyRunner := resiliency.NewRunner[struct{}](ctx, policyDef)
_, err := policyRunner(func(ctx context.Context) (struct{}, error) {
reminders, actorMetadata, rErr := r.getRemindersForActorType(ctx, reminder.ActorType, false)
if rErr != nil {
return struct{}{}, fmt.Errorf("error obtaining reminders for actor type %s: %w", reminder.ActorType, rErr)
}
// First we add it to the partition list.
remindersInPartition, reminderRef, stateKey, etag := actorMetadata.insertReminderInPartition(reminders, *reminder)
// Get the database partition key (needed for CosmosDB)
databasePartitionKey := actorMetadata.calculateDatabasePartitionKey(stateKey)
// Now we can add it to the "global" list.
reminders = append(reminders, reminderRef)
// Check if context is still valid
rErr = ctx.Err()
if rErr != nil {
return struct{}{}, fmt.Errorf("context error before saving reminders: %w", rErr)
}
// Save the partition in the database, in a transaction where we also save the metadata.
// Saving the metadata too avoids a race condition between an update and repartitioning.
stateMetadata := map[string]string{
metadataPartitionKey: databasePartitionKey,
}
partitionOp, err := r.saveRemindersInPartitionRequest(stateKey, remindersInPartition, etag, stateMetadata)
if err != nil {
return struct{}{}, fmt.Errorf("failed to create request for storing reminders: %w", err)
}
stateOperations := []state.TransactionalStateOperation{
partitionOp,
r.saveActorTypeMetadataRequest(reminder.ActorType, actorMetadata, stateMetadata),
}
rErr = r.executeStateStoreTransaction(ctx, storeName, store, stateOperations, stateMetadata)
if rErr != nil {
return struct{}{}, fmt.Errorf("error saving reminders partition and metadata: %w", rErr)
}
if r.metricsCollector != nil {
r.metricsCollector(reminder.ActorType, int64(len(reminders)))
}
r.remindersLock.Lock()
r.reminders[reminder.ActorType] = reminders
r.remindersLock.Unlock()
return struct{}{}, nil
})
if err != nil {
// Remove the value from the in-memory cache
r.activeReminders.CompareAndDelete(reminderKey, stored)
return err
}
return nil
}
func (r *reminders) executeStateStoreTransaction(ctx context.Context, storeName string, store internal.TransactionalStateStore, operations []state.TransactionalStateOperation, metadata map[string]string) error {
var policyDef *resiliency.PolicyDefinition
if r.resiliency != nil && !r.resiliency.PolicyDefined(storeName, resiliency.ComponentOutboundPolicy) {
policyDef = r.resiliency.ComponentOutboundPolicy(storeName, resiliency.Statestore)
} else {
// Else, we can rely on the underlying operations all being covered by resiliency.
noOp := resiliency.NoOp{}
policyDef = noOp.EndpointPolicy("", "")
}
policyRunner := resiliency.NewRunner[struct{}](ctx, policyDef)
stateReq := &state.TransactionalStateRequest{
Operations: operations,
Metadata: metadata,
}
_, err := policyRunner(func(ctx context.Context) (struct{}, error) {
return struct{}{}, store.Multi(ctx, stateReq)
})
return err
}
func (r *reminders) serializeRemindersToProto(reminders []internal.Reminder) ([]byte, error) {
pb := &internalv1pb.Reminders{
Reminders: make([]*internalv1pb.Reminder, len(reminders)),
}
for i, rm := range reminders {
pb.Reminders[i] = &internalv1pb.Reminder{
ActorId: rm.ActorID,
ActorType: rm.ActorType,
Name: rm.Name,
Period: rm.Period.String(),
DueTime: rm.DueTime,
}
if !rm.RegisteredTime.IsZero() {
pb.Reminders[i].RegisteredTime = timestamppb.New(rm.RegisteredTime)
}
if !rm.ExpirationTime.IsZero() {
pb.Reminders[i].ExpirationTime = timestamppb.New(rm.ExpirationTime)
}
if len(rm.Data) > 0 && !bytes.Equal(rm.Data, []byte("null")) {
pb.Reminders[i].Data = rm.Data
}
}
res, err := proto.Marshal(pb)
if err != nil {
return nil, fmt.Errorf("failed to serialize reminders as protobuf: %w", err)
}
// Prepend the prefix "\0pb" to indicate this is protobuf
res = append([]byte{0, 'p', 'b'}, res...)
return res, nil
}
func (r *reminders) unserialize(data []byte) ([]internal.Reminder, error) {
// Check if we have the protobuf prefix
if bytes.HasPrefix(data, []byte{0, 'p', 'b'}) {
return r.unserializeRemindersFromProto(data[3:])
}
// Fallback to unserializing from JSON
var batch []internal.Reminder
err := json.Unmarshal(data, &batch)
return batch, err
}
//nolint:protogetter
func (r *reminders) unserializeRemindersFromProto(data []byte) ([]internal.Reminder, error) {
pb := internalv1pb.Reminders{}
err := proto.Unmarshal(data, &pb)
if err != nil {
return nil, fmt.Errorf("failed to unserialize reminders from protobuf: %w", err)
}
res := make([]internal.Reminder, len(pb.GetReminders()))
for i, rm := range pb.GetReminders() {
if rm == nil {
return nil, errors.New("unserialized reminder object is nil")
}
res[i] = internal.Reminder{
ActorID: rm.ActorId,
ActorType: rm.ActorType,
Name: rm.Name,
DueTime: rm.DueTime,
Period: internal.NewEmptyReminderPeriod(),
}
if len(rm.Data) > 0 {
res[i].Data = rm.Data
}
if rm.Period != "" {
err = res[i].Period.UnmarshalJSON([]byte(rm.Period))
if err != nil {
return nil, fmt.Errorf("failed to unserialize reminder period: %w", err)
}
}
expirationTimePb := rm.GetExpirationTime()
if expirationTimePb != nil && expirationTimePb.IsValid() {
expirationTime := expirationTimePb.AsTime()
if !expirationTime.IsZero() {
res[i].ExpirationTime = expirationTime
}
}
registeredTimePb := rm.GetRegisteredTime()
if registeredTimePb != nil && registeredTimePb.IsValid() {
registeredTime := registeredTimePb.AsTime()
if !registeredTime.IsZero() {
res[i].RegisteredTime = registeredTime
}
}
}
return res, nil
}
func (r *reminders) saveRemindersInPartitionRequest(stateKey string, reminders []internal.Reminder, etag *string, metadata map[string]string) (state.SetRequest, error) {
req := state.SetRequest{
Key: stateKey,
ETag: etag,
Metadata: metadata,
Options: state.SetStateOption{
Concurrency: state.FirstWrite,
},
}
// If APILevelFeatureRemindersProtobuf is enabled, then serialize as protobuf which is more efficient
// Otherwise, fall back to sending the data as-is in the request (which will serialize it as JSON)
if internal.APILevelFeatureRemindersProtobuf.IsEnabled(r.apiLevel.Load()) {
var err error
req.Value, err = r.serializeRemindersToProto(reminders)
if err != nil {
return req, err
}
} else {
req.Value = reminders
}
return req, nil
}
func (r *reminders) saveActorTypeMetadataRequest(actorType string, actorMetadata *ActorMetadata, stateMetadata map[string]string) state.SetRequest {
return state.SetRequest{
Key: constructCompositeKey("actors", actorType, "metadata"),
Value: actorMetadata,
ETag: actorMetadata.Etag,
Metadata: stateMetadata,
Options: state.SetStateOption{
Concurrency: state.FirstWrite,
},
}
}
func (r *reminders) getRemindersForActorType(ctx context.Context, actorType string, migrate bool) ([]ActorReminderReference, *ActorMetadata, error) {
storeName, store, err := r.stateStoreProviderFn()
if err != nil {
return nil, nil, err
}
actorMetadata, err := r.getActorTypeMetadata(ctx, actorType, migrate)
if err != nil {
return nil, nil, fmt.Errorf("could not read actor type metadata: %w", err)
}
var policyDef *resiliency.PolicyDefinition
if r.resiliency != nil && r.resiliency.ComponentOutboundPolicy(storeName, resiliency.Statestore) != nil {
policyDef = r.resiliency.ComponentOutboundPolicy(storeName, resiliency.Statestore)
} else {
// Else, we can rely on the underlying operations all being covered by resiliency.
noOp := resiliency.NoOp{}
policyDef = noOp.EndpointPolicy("", "")
}
log.Debugf(
"Starting to read reminders for actor type %s (migrate=%t), with metadata id %s and %d partitions",
actorType, migrate, actorMetadata.ID, actorMetadata.RemindersMetadata.PartitionCount)
if actorMetadata.RemindersMetadata.PartitionCount >= 1 {
metadata := map[string]string{metadataPartitionKey: actorMetadata.ID}
actorMetadata.RemindersMetadata.PartitionsEtag = map[uint32]*string{}
keyPartitionMap := make(map[string]uint32, actorMetadata.RemindersMetadata.PartitionCount)
getRequests := make([]state.GetRequest, actorMetadata.RemindersMetadata.PartitionCount)
for i := uint32(1); i <= uint32(actorMetadata.RemindersMetadata.PartitionCount); i++ {
key := actorMetadata.calculateRemindersStateKey(actorType, i)
keyPartitionMap[key] = i
getRequests[i-1] = state.GetRequest{
Key: key,
Metadata: metadata,
}
}
var bulkResponse []state.BulkGetResponse
policyRunner := resiliency.NewRunner[[]state.BulkGetResponse](ctx, policyDef)
bulkResponse, err = policyRunner(func(ctx context.Context) ([]state.BulkGetResponse, error) {
return store.BulkGet(ctx, getRequests, state.BulkGetOpts{})
})
if err != nil {
return nil, nil, err
}
list := []ActorReminderReference{}
for _, resp := range bulkResponse {
partition := keyPartitionMap[resp.Key]
actorMetadata.RemindersMetadata.PartitionsEtag[partition] = resp.ETag
if resp.Error != "" {
return nil, nil, fmt.Errorf("could not get reminders partition %v: %v", resp.Key, resp.Error)
}
// Data can be empty if there's no reminder, when serialized as protobuf
var batch []internal.Reminder
if len(resp.Data) == 0 {
return nil, nil, fmt.Errorf("no data found for reminder partition %v: %w", resp.Key, err)
}
batch, err = r.unserialize(resp.Data)
if err != nil {
return nil, nil, fmt.Errorf("could not parse actor reminders partition %v: %w", resp.Key, err)
}
// We can't pre-allocate "list" with the needed capacity because we don't know how many items are in each partition
// However, we can limit the number of times we call "append" on list in a way that could cause the slice to be re-allocated, by managing a separate list here with a fixed capacity and modify "list" just once at per iteration on "bulkResponse".
batchList := make([]ActorReminderReference, len(batch))
for j := range batch {
batchList[j] = ActorReminderReference{
ActorMetadataID: actorMetadata.ID,
ActorRemindersPartitionID: partition,
Reminder: batch[j],
}
}
list = append(list, batchList...)
}
log.Debugf(
"Finished reading reminders for actor type %s (migrate=%t), with metadata id %s and %d partitions: total of %d reminders",
actorType, migrate, actorMetadata.ID, actorMetadata.RemindersMetadata.PartitionCount, len(list))
return list, actorMetadata, nil
}
key := constructCompositeKey("actors", actorType)
policyRunner := resiliency.NewRunner[*state.GetResponse](ctx, policyDef)
resp, err := policyRunner(func(ctx context.Context) (*state.GetResponse, error) {
return store.Get(ctx, &state.GetRequest{
Key: key,
})
})
if err != nil {
return nil, nil, err
}
if resp == nil {
resp = &state.GetResponse{}
}
log.Debugf("Read reminders from %s without partition", key)
var reminders []internal.Reminder
if len(resp.Data) > 0 {
reminders, err = r.unserialize(resp.Data)
if err != nil {
return nil, nil, fmt.Errorf("could not parse actor reminders: %w", err)
}
}
reminderRefs := make([]ActorReminderReference, len(reminders))
for j := range reminders {
reminderRefs[j] = ActorReminderReference{
ActorMetadataID: actorMetadata.ID,
ActorRemindersPartitionID: 0,
Reminder: reminders[j],
}
}
actorMetadata.RemindersMetadata.PartitionsEtag = map[uint32]*string{
0: resp.ETag,
}
log.Debugf(
"Finished reading reminders for actor type %s (migrate=%t), with metadata id %s and no partitions: total of %d reminders",
actorType, migrate, actorMetadata.ID, len(reminderRefs))
return reminderRefs, actorMetadata, nil
}
// getActorMetadata gets the metadata object for the given actor type.
// If "migrate" is true, it also performs migration of reminders if needed. Note that this should be set to "true" only by a caller who owns a lock via evaluationChan.
func (r *reminders) getActorTypeMetadata(ctx context.Context, actorType string, migrate bool) (*ActorMetadata, error) {
storeName, store, err := r.stateStoreProviderFn()
if err != nil {
return nil, err
}
var policyDef *resiliency.PolicyDefinition
if r.resiliency != nil && r.resiliency.PolicyDefined(storeName, resiliency.ComponentOutboundPolicy) {
// If there is no policy defined, wrap the whole logic in the built-in.
policyDef = r.resiliency.BuiltInPolicy(resiliency.BuiltInActorReminderRetries)
} else {
// Else, we can rely on the underlying operations all being covered by resiliency.
noOp := resiliency.NoOp{}
policyDef = noOp.EndpointPolicy("", "")
}
policyRunner := resiliency.NewRunner[*ActorMetadata](ctx, policyDef)
getReq := &state.GetRequest{
Key: constructCompositeKey("actors", actorType, "metadata"),
Metadata: map[string]string{
metadataPartitionKey: constructCompositeKey("actors", actorType),
},
}
return policyRunner(func(ctx context.Context) (*ActorMetadata, error) {
rResp, rErr := store.Get(ctx, getReq)
if rErr != nil {
return nil, rErr
}
actorMetadata := &ActorMetadata{
ID: uuid.Nil.String(),
RemindersMetadata: ActorRemindersMetadata{
PartitionsEtag: nil,
PartitionCount: 0,
},
Etag: nil,
}
if len(rResp.Data) > 0 {
rErr = json.Unmarshal(rResp.Data, actorMetadata)
if rErr != nil {
return nil, fmt.Errorf("could not parse metadata for actor type %s (%s): %w", actorType, string(rResp.Data), rErr)
}
actorMetadata.Etag = rResp.ETag
}
if migrate && ctx.Err() == nil {
rErr = r.migrateRemindersForActorType(ctx, storeName, store, actorType, actorMetadata)
if rErr != nil {
return nil, rErr
}
}
return actorMetadata, nil
})
}
// migrateRemindersForActorType migrates reminders for actors of a given type.
// Note that this method should be invoked by a caller that owns the evaluationChan lock.
func (r *reminders) migrateRemindersForActorType(ctx context.Context, storeName string, store internal.TransactionalStateStore, actorType string, actorMetadata *ActorMetadata) error {
reminderPartitionCount := r.config.GetRemindersPartitionCountForType(actorType)
if actorMetadata.RemindersMetadata.PartitionCount == reminderPartitionCount {
return nil
}
if actorMetadata.RemindersMetadata.PartitionCount > reminderPartitionCount {
log.Errorf("Cannot decrease number of partitions for reminders of actor type %s", actorType)
return nil
}
log.Warnf("Migrating actor metadata record for actor type %s", actorType)
// Fetch all reminders for actor type.
reminderRefs, refreshedActorMetadata, err := r.getRemindersForActorType(ctx, actorType, false)
if err != nil {
return err
}
if refreshedActorMetadata.ID != actorMetadata.ID {
return fmt.Errorf("could not migrate reminders for actor type %s due to race condition in actor metadata", actorType)
}
log.Infof("Migrating %d reminders for actor type %s", len(reminderRefs), actorType)
*actorMetadata = *refreshedActorMetadata
// Recreate as a new metadata identifier.
idObj, err := uuid.NewRandom()
if err != nil {
return fmt.Errorf("failed to generate UUID: %w", err)
}
actorMetadata.ID = idObj.String()
actorMetadata.RemindersMetadata.PartitionCount = reminderPartitionCount
actorRemindersPartitions := make([][]internal.Reminder, actorMetadata.RemindersMetadata.PartitionCount)
for i := 0; i < actorMetadata.RemindersMetadata.PartitionCount; i++ {
actorRemindersPartitions[i] = make([]internal.Reminder, 0)
}
// Recalculate partition for each reminder.
for _, reminderRef := range reminderRefs {
partitionID := actorMetadata.calculateReminderPartition(reminderRef.Reminder.ActorID, reminderRef.Reminder.Name)
actorRemindersPartitions[partitionID-1] = append(actorRemindersPartitions[partitionID-1], reminderRef.Reminder)
}
// Create the requests to put in the transaction.
stateOperations := make([]state.TransactionalStateOperation, actorMetadata.RemindersMetadata.PartitionCount+1)
stateMetadata := map[string]string{
metadataPartitionKey: actorMetadata.ID,
}
for i := 0; i < actorMetadata.RemindersMetadata.PartitionCount; i++ {
stateKey := actorMetadata.calculateRemindersStateKey(actorType, uint32(i+1))
stateOperations[i], err = r.saveRemindersInPartitionRequest(stateKey, actorRemindersPartitions[i], nil, stateMetadata)
if err != nil {
return fmt.Errorf("failed to create request for reminders in partition %d: %w", i, err)
}
}
// Also create a request to save the new metadata, so the new "metadataID" becomes the new de facto referenced list for reminders
stateOperations[len(stateOperations)-1] = r.saveActorTypeMetadataRequest(actorType, actorMetadata, stateMetadata)
// Perform all operations in a transaction
err = r.executeStateStoreTransaction(ctx, storeName, store, stateOperations, stateMetadata)
if err != nil {
return fmt.Errorf("failed to perform transaction to migrate records for actor type %s: %w", actorType, err)
}
log.Warnf("Completed actor metadata record migration for actor type %s, new metadata ID = %s", actorType, actorMetadata.ID)
return nil
}
func constructCompositeKey(keys ...string) string {
return strings.Join(keys, daprSeparator)
}
func (r *reminders) startReminder(reminder *internal.Reminder, stopChannel chan struct{}) error {
reminderKey := reminder.Key()
track, err := r.getReminderTrack(context.TODO(), reminderKey)
if err != nil {
return fmt.Errorf("error getting reminder track: %w", err)
}
reminder.UpdateFromTrack(track)
go func() {
var (
nextTimer clock.Timer