Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STATE - Get State Operation should support sending metadata #1909

Closed
perokvist opened this issue Aug 14, 2020 · 6 comments · Fixed by #1965
Closed

STATE - Get State Operation should support sending metadata #1909

perokvist opened this issue Aug 14, 2020 · 6 comments · Fixed by #1965

Comments

@perokvist
Copy link

The client state operations for "get" does not take a metadata dictionary.
This makes using "partitionKey" in the cosmos state component "impossible".

cosmos state component usage.

@amanbha
Copy link
Contributor

amanbha commented Aug 14, 2020

Thanks for reporting it @perokvist . I am transferring it to dapr/dapr repo as the grpc GET state api doesn't accept metadata.

@amanbha amanbha transferred this issue from dapr/dotnet-sdk Aug 14, 2020
@amanbha
Copy link
Contributor

amanbha commented Aug 14, 2020

cc @yaron2 @youngbupark

@youngbupark
Copy link

ack. I think this should be P1 ?

@youngbupark
Copy link

@yaron2 @amanbha do we want to fix this in this milestone? In this case, we need to add metadata property to all state apis.

cc/ @orizohar @msfussell @yolember

@amanbha
Copy link
Contributor

amanbha commented Aug 17, 2020

@youngbupark this will not be breaking, correct? its addition to existing api and given that today is code freeze, it can come in next release.

@youngbupark
Copy link

@youngbupark this will not be breaking, correct? its addition to existing api and given that today is code freeze, it can come in next release.

this should not be a breaking change. it is just addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants