Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hardcoded ints to constant values in http/api.go #2070

Closed
vinayada1 opened this issue Sep 17, 2020 · 0 comments · Fixed by #2258
Closed

Change hardcoded ints to constant values in http/api.go #2070

vinayada1 opened this issue Sep 17, 2020 · 0 comments · Fixed by #2258
Assignees
@mukundansundar
Labels
area/runtime size/XS 2 days work
Projects
1.0.0 Milestone 1 1.0.0 Milestone

Comments

@vinayada1
Copy link
Contributor

vinayada1 commented Sep 17, 2020 •
edited by mukundansundar

In what area(s)?

/area runtime

What version of Dapr?

0.10.0

Output of git describe --dirty

Expected Behavior

Use constants for more code readability for status codes in http/api.go.

Actual Behavior

hardcoded ints such as 403 are used.

Release Notes

RELEASE NOTE: UPDATE Change hardcoded integer status codes to constants for HTTP API
@vinayada1 vinayada1 added the kind/bug Something isn't working label Sep 17, 2020
@mukundansundar mukundansundar removed the kind/bug Something isn't working label Sep 17, 2020
@mukundansundar mukundansundar added this to To do in 1.0.0 Milestone 1 via automation Sep 23, 2020
@mukundansundar mukundansundar moved this from To do to In progress in 1.0.0 Milestone 1 Oct 12, 2020
@mukundansundar mukundansundar mentioned this issue Oct 14, 2020
Merged
7 tasks
1.0.0 Milestone 1 automation moved this from In progress to Review Oct 15, 2020
@artursouza artursouza moved this from Review to Done in 1.0.0 Milestone 1 Oct 15, 2020
@artursouza artursouza added this to Release in 1.0.0 Milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukundansundar mukundansundar

Labels
area/runtime size/XS 2 days work
Projects
No open projects
1.0.0 Milestone
  
Done
1.0.0 Milestone 1
  
Release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace http status code with constants mukundansundar/dapr
3 participants
@youngbupark @vinayada1 @mukundansundar