Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement needs a configurable healthz port #2242

Closed
yaron2 opened this issue Oct 12, 2020 · 1 comment · Fixed by #2244
Closed

Placement needs a configurable healthz port #2242

yaron2 opened this issue Oct 12, 2020 · 1 comment · Fixed by #2244
Assignees
Labels
kind/bug Something isn't working P1

Comments

@yaron2
Copy link
Member

yaron2 commented Oct 12, 2020

Currently, the healthz port for the placement service is always 8080 with no configurable option to set the port.
This can cause the placement service to throw an error when running on a machine where port 8080 is taken.

First reported by @samcov here.

The error does not prevent from the Placement Service to function normally.

Release Note

RELEASE NOTE: Added configurable healthz port for placement service

@yaron2
Copy link
Member Author

yaron2 commented Oct 12, 2020

Update: we log.Fatal for failing to start the healthz server which exists the process, which makes the placement service exit if a healthz port is already used.

@yaron2 yaron2 removed the P2 label Oct 12, 2020
@yaron2 yaron2 self-assigned this Oct 12, 2020
@yaron2 yaron2 added this to To do in 1.0.0 Milestone 1 via automation Oct 12, 2020
@yaron2 yaron2 moved this from To do to In progress in 1.0.0 Milestone 1 Oct 12, 2020
1.0.0 Milestone 1 automation moved this from In progress to Review Oct 12, 2020
@artursouza artursouza moved this from Review to Done in 1.0.0 Milestone 1 Oct 13, 2020
@artursouza artursouza added this to Release in 1.0.0 Milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working P1
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant