Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry exporter uses out-dated/wrong attribute keys #2288

Closed
tcnghia opened this issue Oct 19, 2020 · 3 comments · Fixed by #2293
Closed

OpenTelemetry exporter uses out-dated/wrong attribute keys #2288

tcnghia opened this issue Oct 19, 2020 · 3 comments · Fixed by #2293
Assignees
Labels
area/runtime kind/bug Something isn't working kind/observability Dapr observability related P1

Comments

@tcnghia
Copy link
Member

tcnghia commented Oct 19, 2020

In what area(s)?

/area runtime

What version of Dapr?

All versions up to 0.11

Expected Behavior

OpenTelemetry exporter uses updated attribute keys.

Actual Behavior

We observed in dapr/docs#870 that Dapr uses attribute keys from older OpenTelemetry spec. Samples of a few mismatches:

  • db.type is now db.system
  • db.url is now db.connection_string
  • db.instance is now db.name
  • There may be more

See latest OpenTelemetry spec .

See current attribute keys in Dapr

Steps to Reproduce the Problem

Go through the documentation in dapr/docs#870 and see that the statestore calls are not showing correctly. Instead of "STATE", we see "OTHER".

Release Note

RELEASE NOTE: FIX Update OpenTelemetry attribute keys db.{type,url,instance} to the latest spec db.{system,connection_string,name}

@tcnghia tcnghia added the kind/bug Something isn't working label Oct 19, 2020
@tcnghia
Copy link
Member Author

tcnghia commented Oct 19, 2020

cc @youngbupark @yaron2

@youngbupark
Copy link

@msfussell @yaron2 I marked this issue as P1. we should fix it to use OTEL collector.

@tcnghia
Copy link
Member Author

tcnghia commented Oct 20, 2020

I'm working on fixing this to unblock #1080

@tcnghia tcnghia self-assigned this Oct 20, 2020
@youngbupark youngbupark moved this from To do to In progress in 1.0.0 Milestone 1 Oct 20, 2020
@tcnghia tcnghia changed the title OpenTelemetry exporter use out-dated attribute keys OpenTelemetry exporter uses out-dated attribute keys Oct 21, 2020
@tcnghia tcnghia changed the title OpenTelemetry exporter uses out-dated attribute keys OpenTelemetry exporter uses out-dated/wrong attribute keys Oct 21, 2020
1.0.0 Milestone 1 automation moved this from In progress to Review Oct 21, 2020
@artursouza artursouza moved this from Review to Done in 1.0.0 Milestone 1 Oct 22, 2020
@artursouza artursouza added this to Release in 1.0.0 Milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime kind/bug Something isn't working kind/observability Dapr observability related P1
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants