Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapr sidecar will stop working when input binding message processing time is longer than 60 seconds #2301

Closed
Li-Yanzhi opened this issue Oct 22, 2020 · 3 comments · Fixed by #2305

Comments

@Li-Yanzhi
Copy link
Contributor

Li-Yanzhi commented Oct 22, 2020

Release Note

RELEASE NOTE: Removed 60 seconds timeout on app channel

@Li-Yanzhi Li-Yanzhi added the kind/bug Something isn't working label Oct 22, 2020
@youngbupark
Copy link

This is because the 60s timeout of app channel. I think it makes sense to allows to set custom timeout. We may need to allow internal gRPC channel timeout to be configurable as well.

@yaron any thoughts?

cc/ @msfussell @yolember

@yaron2
Copy link
Member

yaron2 commented Oct 22, 2020

This is because the 60s timeout of app channel. I think it makes sense to allows to set custom timeout. We may need to allow internal gRPC channel timeout to be configurable as well.

@yaron any thoughts?

cc/ @msfussell @yolember

Actually this is a bug the way this behaves currently. The most immediate resolution is to remove the timeout. An app can take as long as it wants. In the future we can make this configurable, this intersects with custom retries which are post RC1.0. but for now, the timeout should be removed.

@yaron2 yaron2 added the P1 label Oct 22, 2020
@yaron2 yaron2 self-assigned this Oct 22, 2020
@yaron2 yaron2 added this to To do in 1.0.0 Milestone 1 via automation Oct 22, 2020
@yaron2 yaron2 moved this from To do to In progress in 1.0.0 Milestone 1 Oct 22, 2020
1.0.0 Milestone 1 automation moved this from In progress to Review Oct 22, 2020
@yaron2
Copy link
Member

yaron2 commented Oct 22, 2020

@Li-Yanzhi this is now fixed.

@artursouza artursouza added this to To do in 1.0.0 Milestone via automation Oct 22, 2020
@artursouza artursouza moved this from Review to Done in 1.0.0 Milestone 1 Oct 22, 2020
@abserari abserari mentioned this issue Oct 24, 2020
7 tasks
@yaron2 yaron2 moved this from To do to Done in 1.0.0 Milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants