Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the warning: WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated #2313

Closed
youngbupark opened this issue Oct 23, 2020 · 3 comments · Fixed by #2384
Closed

Remove the warning: WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated #2313

youngbupark opened this issue Oct 23, 2020 · 3 comments · Fixed by #2384
Assignees
@yaron2
Labels
area/runtime kind/bug Something isn't working P1
Projects
1.0.0 Milestone 1 1.0.0 Milestone

Comments

@youngbupark
Copy link

youngbupark commented Oct 23, 2020 •
edited by yaron2

Release Note

RELEASE NOTE: Removed package deprecation warning for protoc-gen-go
@youngbupark youngbupark added the kind/bug Something isn't working label Oct 23, 2020
@youngbupark youngbupark changed the title Remove the warning: WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated. A future release of golang/protobuf will delete this package, which has long been excluded from the compatibility promise. Remove the warning: WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated Oct 23, 2020
@youngbupark
Copy link
Author

@yaron2 @skyao I think this is related to gRPC pkg upgrade.

@youngbupark youngbupark added this to To do in 1.0.0 Milestone 1 via automation Oct 23, 2020
@yaron2 yaron2 self-assigned this Oct 23, 2020
@yaron2
Copy link
Member

yaron2 commented Oct 23, 2020

This message appears because the native exporter in contrib is using grpc-gateway which is depending on this package.

Based on our changes to exporters, we can blanket remove all exporters, is that correct?

@skyao
Copy link
Member

skyao commented Oct 27, 2020

It seems that this warning dues to the project "github.com/census-instrumentation/opencensus-proto/": this project is version v0.2.0 which release in March 2019 and no more release after this. And project "github.com/grpc-ecosystem/grpc-gateway" has moved so fast from 1.9.4 to 1.15.2 and 2.0.1:

 % go mod why github.com/golang/protobuf/protoc-gen-go/generator
# github.com/golang/protobuf/protoc-gen-go/generator
github.com/dapr/dapr/cmd/daprd
github.com/dapr/components-contrib/exporters/native
contrib.go.opencensus.io/exporter/ocagent
github.com/census-instrumentation/opencensus-proto/gen-go/agent/metrics/v1
github.com/grpc-ecosystem/grpc-gateway/runtime
github.com/golang/protobuf/protoc-gen-go/generator

@artursouza artursouza added this to To do in 1.0.0 Milestone Oct 27, 2020
@artursouza artursouza moved this from To do to Planned in 1.0.0 Milestone 1 Nov 3, 2020
@artursouza artursouza moved this from Planned to To do in 1.0.0 Milestone 1 Nov 3, 2020
@artursouza artursouza moved this from To do to In progress in 1.0.0 Milestone 1 Nov 4, 2020
@yaron2 yaron2 mentioned this issue Nov 4, 2020
Merged
1.0.0 Milestone 1 automation moved this from In progress to Review Nov 4, 2020
1.0.0 Milestone automation moved this from To do to Done Nov 4, 2020
@artursouza artursouza moved this from Review to Done in 1.0.0 Milestone 1 Nov 6, 2020
@artursouza artursouza moved this from Done to Release in 1.0.0 Milestone 1 Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaron2 yaron2

Labels
area/runtime kind/bug Something isn't working P1
Projects
No open projects
1.0.0 Milestone
  
Done
1.0.0 Milestone 1
  
Release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ocagent dependency
3 participants
@skyao @youngbupark @yaron2