Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daprd loads components instead of skipping if exists when operator stream reconnects #4212

Closed
yaron2 opened this issue Feb 7, 2022 · 2 comments · Fixed by #4213
Closed
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@yaron2
Copy link
Member

yaron2 commented Feb 7, 2022

This issue is the root cause for #3946 and dapr/components-contrib#1318.

In daprd, the check between the old component vs new component will determine they are not equal, and daprd will proceed with loading all existing components again. This will happen every time that a component is updated (just a label update, for example, that should not cause daprd to load the component again) or when the operator crashes.

@yaron2 yaron2 added the kind/bug Something isn't working label Feb 7, 2022
@yaron2 yaron2 self-assigned this Feb 7, 2022
@yaron2
Copy link
Member Author

yaron2 commented Feb 7, 2022

cc @artursouza @daixiang0 do we want to release this as 1.6.1? On one hand, we've had this bug since ~1.3.x, on the other hand, this is a pretty nasty issue.

@daixiang0
Copy link
Member

cc @artursouza @daixiang0 do we want to release this as 1.6.1? On one hand, we've had this bug since ~1.3.x, on the other hand, this is a pretty nasty issue.

Agree.

@yaron2 yaron2 added this to the v1.7 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants