Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration: Flakey actor tests #7250

Closed
JoshVanL opened this issue Nov 28, 2023 · 2 comments · Fixed by #7296
Closed

Integration: Flakey actor tests #7250

JoshVanL opened this issue Nov 28, 2023 · 2 comments · Fixed by #7296
Assignees
@yaron2
Labels
kind/bug Something isn't working P0
Milestone
v1.13

Comments

@JoshVanL
Copy link
Contributor

Currently, the integration tests are flaky and almost never pass on the MacOS runner.

These errors are usually exclusively due to actor related tests, for example Test_Integration/actors/reminders/rebalancing:

2023-11-27T22:12:57.5972570Z 2023/11/27 22:12:43 Failed to report status to placement; will retry: error from placement: rpc error: code = FailedPrecondition desc = The cluster's Actor API level is 10, which is higher than the reported API level 0

Integration tests should be made stable/bugs fixed, ideally before any other actor related features are merged.
@JoshVanL JoshVanL added kind/bug Something isn't working P0 labels Nov 28, 2023
@JoshVanL JoshVanL added this to the v1.13 milestone Nov 28, 2023
This was referenced Nov 29, 2023
Merged
Merged
@ItalyPaleAle
Copy link
Contributor

Fix is in #7129. Unclear why it only appears on macOS (probably due to some timings)

@mukundansundar
Copy link
Contributor

@ItalyPaleAle can the fix for this be a separate PR? that will unblock the other PRs that target Actors

@JoshVanL JoshVanL mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaron2 yaron2

Labels
kind/bug Something isn't working P0
Projects
v1.13 Release Tracking Board
Status: Done
Milestone
v1.13
Development

Successfully merging a pull request may close this issue.

Integration: Remove data race in: suite/actors/reminders/rebalancing.go JoshVanL/dapr
4 participants
@ItalyPaleAle @JoshVanL @yaron2 @mukundansundar