Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart Docs: global.tolerations should be array [] and not object {} #7499

Closed
avo-sepp opened this issue Feb 5, 2024 · 0 comments · Fixed by #7500
Closed

Helm Chart Docs: global.tolerations should be array [] and not object {} #7499

avo-sepp opened this issue Feb 5, 2024 · 0 comments · Fixed by #7500
Assignees
Milestone

Comments

@avo-sepp
Copy link
Contributor

avo-sepp commented Feb 5, 2024

Kubernetes Tolerations are represented as an array, example:

tolerations:
- key: "key1"
  operator: "Equal"
  value: "value1"
  effect: "NoSchedule"

The Helm chart for Dapr Operator only uses toYaml to bring in the values from values.yaml, there is no processing of an object.

{{- if .Values.global.tolerations }}
      tolerations:
{{ toYaml .Values.global.tolerations | indent 8 }}
{{- end }}

I think mapping from Object to Array works, I have not confirmed, but it is confusing from a documentation standpoint to see object {} in the README.md when I would expect array []

@avo-sepp avo-sepp changed the title Helm Chart: global.tolerations should be array [] and not object {} Helm Chart Docs: global.tolerations should be array [] and not object {} Feb 5, 2024
@yaron2 yaron2 added this to the v1.13 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants