Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hight cardinality metrics are shown for actors but increasedCardinality is set to false #7736

Open
fabistb opened this issue May 16, 2024 · 1 comment · May be fixed by #7756
Open

hight cardinality metrics are shown for actors but increasedCardinality is set to false #7736

fabistb opened this issue May 16, 2024 · 1 comment · May be fixed by #7756
Labels
kind/bug Something isn't working P0
Milestone

Comments

@fabistb
Copy link

fabistb commented May 16, 2024

In what area(s)?

/area runtime

What version of Dapr?

1.13.2

Expected Behavior

When setting in the appconfig increasedCardinality to false I don't expect any high cardinality metrics in the logging server.

App Config:

kind: Configuration
spec:
  metric:
    http:
      increasedCardinality: false

Actual Behavior

There are now new high cardinality dapr_http_server_latency_bucket metcis related to the InvokeActor method.

dapr_http_server_latency_bucket{app_id="supplement",method="InvokeActor/SupplementActor.7fba4d69-bd63-4782-83aa-f523223c26df",status="200",le="50000"} 3
dapr_http_server_latency_bucket{app_id="supplement",method="InvokeActor/SupplementActor.7fba4d69-bd63-4782-83aa-f523223c26df",status="200",le="100000"} 3
dapr_http_server_latency_bucket{app_id="supplement",method="InvokeActor/SupplementActor.7fba4d69-bd63-4782-83aa-f523223c26df",status="200",le="+Inf"} 3
dapr_http_server_latency_sum{app_id="supplement",method="InvokeActor/SupplementActor.7fba4d69-bd63-4782-83aa-f523223c26df",status="200"} 357
dapr_http_server_latency_count{app_id="supplement",method="InvokeActor/SupplementActor.7fba4d69-bd63-4782-83aa-f523223c26df",status="200"} 3
dapr_http_server_latency_bucket{app_id="supplement",method="InvokeActor/SupplementActor.8032a1a1-ec2e-4518-965c-a9ad9adbff31",status="200",le="1"} 0
dapr_http_server_latency_bucket{app_id="supplement",method="InvokeActor/SupplementActor.8032a1a1-ec2e-4518-965c-a9ad9adbff31",status="200",le="2"} 0
dapr_http_server_latency_bucket{app_id="supplement",method="InvokeActor/SupplementActor.8032a1a1-ec2e-4518-965c-a9ad9adbff31",status="200",le="3"} 0
dapr_http_server_latency_bucket{app_id="supplement",method="InvokeActor/SupplementActor.8032a1a1-ec2e-4518-965c-a9ad9adbff31",status="200",le="4"} 0
dapr_http_server_latency_bucket{app_id="supplement",method="InvokeActor/SupplementActor.8032a1a1-ec2e-4518-965c-a9ad9adbff31",status="200",le="5"} 0

I haven't seen these metrics related to actors in previous Dapr versions.
Based on my expectation configuring the increasedCardinality to false should also prevent these high cardinality metrics to appear.

Release Note

FIX Actor related high cardinlity metrics when increasedCardinality is set to false.

@fabistb fabistb added the kind/bug Something isn't working label May 16, 2024
@alicejgibbons
Copy link
Contributor

Just a note this looks to have been introduced in 1.13.x as this was not seen before in previous dapr versions with actors metrics even when using the regex low cardinality method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working P0
Projects
Status: Needs Owner
Development

Successfully merging a pull request may close this issue.

3 participants