BUG: Potential logical bug in file dapr/pkg/actors/actors.go

[fazledyn-or]

In what area(s)?

/area runtime

What version of Dapr?

Latest master branch

Expected Behavior

Not relevant. See description.

Actual Behavior

Not relevant. See description.

Description

While triaging your project, our bug fixing tool found a bug in file: actors.go. After inspecting the code, we found out that in the goroutine below, there are two send operations to channel errCh. One of these send operation is conditional (if the err value is not nil), and the other is normal.

go func(key any) {
    actorKey := key.(string)
    err := a.haltActor(a.getActorTypeAndIDFromKey(actorKey))
    if err != nil {
        errCh <- fmt.Errorf("failed to deactivate actor '%s': %v", actorKey, err)
    }
    errCh <- nil
}(key)

It looks like the channel is sent more values than it should. The correct condition should be as below-

if err != nil {
    errCh <- fmt.Errorf("failed to deactivate actor '%s': %v", actorKey, err)
} else {
    errCh <- nil
}

- From Dapr Discord Channel

Steps to Reproduce the Problem

Not relevant.

Fix

I'm going to create a PR to address and fix this bug.

Release Note

RELEASE NOTE: FIX Logical bug in runtime