Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret Not Found - Inconsistent error codes #1637

Closed
XavierGeerinck opened this issue Jul 13, 2021 · 0 comments
Closed

Secret Not Found - Inconsistent error codes #1637

XavierGeerinck opened this issue Jul 13, 2021 · 0 comments

Comments

@XavierGeerinck
Copy link
Contributor

URL of the docs page

https://docs.dapr.io/reference/api/secrets_api/#http-response

How is it currently worded?

204 | Secret not found

How should it be worded?

404 | Secret not found

Screenshots

Additional context

Related to #1636 where there is inconsistency across status codes on actors. Similar to secrets, suddenly 204 is being used instead of 404 or 400 here.

This is important, since 4xx or 5xx typically should throw an error, while 2xx should return a response (albeit empty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants