Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE PREVIEW: Add Actor State TTL support #1078

Closed
JoshVanL opened this issue Apr 25, 2023 · 6 comments
Closed

FEATURE PREVIEW: Add Actor State TTL support #1078

JoshVanL opened this issue Apr 25, 2023 · 6 comments
Assignees
Labels
area/actor good first issue Good for newcomers kind/enhancement New feature or request
Milestone

Comments

@JoshVanL
Copy link
Contributor

Add first class API support for Actor State TTL dapr/dapr#5899

A dedicated function to Actor State should be created. Psudo code: func (key string, value string, ttl duration). It should be made clear in the SDK documentation/comments that users should always use this function, unless they have specifically created some kind of Actor State clean up out of band of Dapr or don't have an issue with the Actor State store keep state and grow "forever".

Please see the go-sdk for implementation reference.

@JoshVanL JoshVanL added the kind/enhancement New feature or request label Apr 25, 2023
@artursouza artursouza added the good first issue Good for newcomers label May 15, 2023
@JoshVanL JoshVanL changed the title Add Actor State TTL support FEATURE PREVIEW: Add Actor State TTL support May 25, 2023
@JoshVanL
Copy link
Contributor Author

UPDATE: Due to the nature of the current implementation of write through caching of actor state and the unavailability of the real TTL expire time of state keys, SDKs will have an inconsistent view of the world when it has a cold cache and the state store has TTL keys. The TTL functionality has been put behind a feature gate in daprd. See dapr/dapr#6400 for more details. This feature is expected to be moved to GA in 1.12.

@artursouza artursouza modified the milestone: v1.12 Jun 29, 2023
@artursouza
Copy link
Member

Can this be added in 1.12?

@onionhammer
Copy link
Contributor

Any update on this?

@srparupu
Copy link

/assign

@sicoyle
Copy link

sicoyle commented Sep 22, 2023

@srparupu Please let us know if you need help with anything, and when you open a PR with the changes so we can move this issue in the board to "In review"! Thank youuuuu :)

@halspang
Copy link
Contributor

halspang commented Jan 8, 2024

This was handled by: #1164

@halspang halspang closed this as completed Jan 8, 2024
@halspang halspang added this to the v1.13 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/actor good first issue Good for newcomers kind/enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

6 participants