-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pass W3C trace header or grpc-trace-bin to dapr api call #300
Comments
@shalabhms @amanbha @LMWF It would be good to think about how to allow users to use their own trace id in dotnet-sdk, but I understand there were no strong requests from customers. |
.NET Core 3.0+ will propagate the W3C header format by default if the appropriate headers are set on the inbound request. It's also a good idea overall to add the guidance to set this property to the W3C value in
If you want to customize the ID then typically I think you'd set This whole flow should be fairly automatic since these features are built-in to .NET as a platform. I'm surprised if it's not already working 😆 |
Need to validate |
@LMWF , this has been validated . Need to have workaround fix dapr/dapr#1816 for the scenario to work. You can find the zipkin trace image for the test in the PR. |
dapr runtime added a workaround until grpc-dotnet client is fixed. |
Describe the proposal
Allow to pass W3C trace header(
traceparent
) orgrpc-trace-bin
to dapr api call.0.7.0 supports traceparent and grpc-trace-bin. Dotnet-sdk needs the way to pass
traceparent
for http orgrpc-trace-bin
metadata for grpc.The text was updated successfully, but these errors were encountered: