Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure logging levels? #406

Closed
clintsinger opened this issue Sep 30, 2020 · 2 comments · Fixed by #453 or #460
Closed

Configure logging levels? #406

clintsinger opened this issue Sep 30, 2020 · 2 comments · Fixed by #453 or #460
Assignees
@vinayada1
Labels
kind/enhancement New feature or request P1
Projects
1.0.0 Milestone 1 1.0.0-RC1 Milestone features 1.0.0 Milestone

Comments

@clintsinger
Copy link

clintsinger commented Sep 30, 2020 •
edited by artursouza

Ask your question here

Perhaps, I'm missing something but there doesn't seem to be a way to configure the log level of the Dapr C# SDK. For example, I would like to filter out the "Activated, Deactivated" messages which are at Info level and only show warning level traces.

Did I miss what the settings are or should this be a feature request?

RELEASE NOTE: ADD configurable log level in .Net SDK.
@vinayada1 vinayada1 added the kind/enhancement New feature or request label Sep 30, 2020
@vinayada1
Copy link
Contributor

This should be a feature request. Updated the tag on the issue.

@rynowak
Copy link
Collaborator

rynowak commented Oct 7, 2020

We should do this, and integrate with ILogger as part of the ASP.NET Core integration rather than doing console logging unconditionally. This allows us to adopt structured logging and leverage existing systems rather than building a new one.

Related to: #416

@vinayada1 vinayada1 added this to To do in 1.0.0 Milestone 1 via automation Oct 15, 2020
@artursouza artursouza added the P1 label Oct 15, 2020
@artursouza artursouza added this to To do in 1.0.0 Milestone Oct 27, 2020
@artursouza artursouza moved this from To do to In progress in 1.0.0 Milestone 1 Oct 27, 2020
@msfussell msfussell moved this from To do to In progress in 1.0.0-RC1 Milestone features Oct 28, 2020
@vinayada1 vinayada1 mentioned this issue Oct 28, 2020
Merged
3 tasks
1.0.0 Milestone 1 automation moved this from In progress to Review Oct 30, 2020
1.0.0 Milestone automation moved this from To do to Done Oct 30, 2020
@artursouza artursouza moved this from Review to Done in 1.0.0 Milestone 1 Nov 4, 2020
@artursouza artursouza moved this from Done to Release in 1.0.0 Milestone 1 Nov 4, 2020
@vinayada1 vinayada1 mentioned this issue Nov 4, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinayada1 vinayada1

Labels
kind/enhancement New feature or request P1
Projects
No open projects
1.0.0 Milestone
  
Done
1.0.0 Milestone 1
  
Release
1.0.0-RC1 Milestone features
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Logging changes to use ILogger dapr/dotnet-sdk
naming convention dapr/dotnet-sdk
4 participants
@artursouza @rynowak @clintsinger @vinayada1