Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moar gRPC? #92

Closed
rynowak opened this issue Oct 12, 2019 · 3 comments
Closed

Moar gRPC? #92

rynowak opened this issue Oct 12, 2019 · 3 comments

Comments

@rynowak
Copy link
Collaborator

rynowak commented Oct 12, 2019

Now that we've got a gRPC client - do we want to take a more thorough look at the experience for ASP.NET Core + gRPC + Dapr? I happen to know a guy.

At this minimum this would probably be a review of some of the practices + more samples, at the maximum we might identify more features and integration points.

@amanbha
Copy link
Contributor

amanbha commented Oct 14, 2019

Yes, @rynowak we need to refine this experience. The gRPC client is currently autogenerated, to make it more user friendly will probably need some wrapper. The help would be really appreciated.
I would like to propose following client packages structure to give better usability to SDK:
Dapr.Client. (will contain interfaces and helper methods)
Dapr.Client.Http. (will contain http implementation of interfaces in Dapr.Client
Dapr.Client.Grpc (currently it's fully autogenerated, but it can have Dapr.Client interface implementations that calls into autogen code)
But it wont happen for the OSS release on 10/`6/19.

@mehmetuken mehmetuken mentioned this issue Nov 15, 2019
3 tasks
@jeastham1993
Copy link
Contributor

@amanbha Not familiar enough with gRPC in dotnet core to help with a gRPC wrapper, but happy to help with the grunt work on the restructuring on the client packages if needed.

@amanbha
Copy link
Contributor

amanbha commented Mar 10, 2020

Closed by #244

@amanbha amanbha closed this as completed Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants