Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more xo(ro)shiro RNGs #56

Closed
rstub opened this issue Sep 7, 2023 · 0 comments · Fixed by #57
Closed

Support more xo(ro)shiro RNGs #56

rstub opened this issue Sep 7, 2023 · 0 comments · Fixed by #57

Comments

@rstub
Copy link
Member

rstub commented Sep 7, 2023

Currently only xoroshiro128+ and xoshiro256+ from https://prng.di.unimi.it/ are supported. These RNGs should only be used for creating floating point numbers, which was the case for {dqrng} originally. However, dqsample and dqrrademacher make use of the full bit pattern. So it would be better to support the ** and/or ++ variants and make one of them the default. This would be a breaking change, of course.

In addition, the templating mechanism in xoshiro.h does not really work. Probably best to resort to a simpler template with just the state size and a virtual next() which is then explicitly implemented in per-RNG derived classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant